Repository navigation
chore(deps): bump npm CLI pins to current versions - #1592
Conversation
Bump the seven npm-installed CLI pins in Dockerfile.unified, Dockerfile.package and the matching Dockerfile.<agent> files. Mirrors the npm bumps in #1550. - copilot 1.0.89 to 1.0.105 (@github/copilot, registry check: 1.0.105 confirmed) - gemini-cli 0.61.0 to 0.66.0 (@google/gemini-cli, registry check: 0.66.0 confirmed) - opencode 1.18.33 to 1.19.5 (opencode-ai, registry check: 1.19.5 confirmed) - mimocode 0.1.15 to 0.1.16 (@mimo-ai/cli, registry check: 0.1.16 confirmed) - kimi-code 2.1.1 to 2.4.1 (@moonshot-ai/kimi-code, registry check: 2.4.1 confirmed) - codex 0.159.0 to 0.166.0 (@openai/codex, registry check: 0.166.0 confirmed) - pi-acp 0.0.31 to 0.0.34 (pi-acp, registry check: 0.0.34 confirmed) Grep verification: no old value remains in the nine changed files. 21 ARG lines changed: 7 in Dockerfile.unified, 7 in Dockerfile.package, 1 in each of Dockerfile.codex, copilot, gemini, kimi, mimocode, opencode, pi. Known gap: .github/workflows/docker-smoke-test.yml lines 211 and 212 still assert the old CODEX_VERSION=0.159.0 and COPILOT_VERSION=1.0.89. That file is outside this PR, so the docker smoke test fails until those assertions are updated.
Update the two stale assert_line checks in docker-smoke-test.yml to the pins now in Dockerfile.unified, Dockerfile.package and the per-agent Dockerfiles: - CODEX_VERSION 0.159.0 -> 0.166.0 - COPILOT_VERSION 1.0.89 -> 1.0.105 Checks run before committing: - grep for ARG CODEX_VERSION / COPILOT_VERSION across Dockerfile.codex, Dockerfile.copilot, Dockerfile.package, Dockerfile.unified: all match the new values; CODEX_ACP_VERSION and the other assertions already match. - grep of docker-smoke-test.yml for 0.159.0 and 1.0.89: no matches. - grep of docker-smoke-test.yml for the new values: lines 211 and 212. - git diff: only these two lines changed.
This comment has been minimized.
This comment has been minimized.
|
Note LGTM ✅ - The seven npm pin bumps are consistent across all Dockerfile copies, CI is fully green, and the round 1 description finding is resolved. What This PR DoesBumps seven npm-distributed CLI version pins (copilot, gemini-cli, opencode, mimocode, kimi-code, codex, pi-acp) to the versions currently published on npm, so the release images match the nightly build. How It WorksEach pin is an Findings
Finding Details🟢 F1: Round 1 description finding resolvedRound 1 requested changes because the PR body contradicted the diff. The updated description now:
The Review Contract check re-ran after the edit (run 41220450106) and passed. The head SHA did not change; the fix was description-only. 🟢 F2: Consistent pin updatesEvery one of the seven pins reads the new value in all three Dockerfiles that carry it. A grep for each old value ( 🟢 F3: CI contract kept in syncThe second commit updates the hardcoded Codex and Copilot expectations together with the Dockerfiles, so the pin-parity gate stays meaningful rather than being bypassed. 🟢 F4: CI fully greenAll 🟢 F5: Registry and runtime compatibilityAll seven new versions return HTTP 200 from Follow-up (non-blocking, out of scope for this PR)Pin parity is still maintained by hand. This is pre-existing design that the PR does not introduce, so it does not affect the verdict. Baseline Check
What's Good (🟢)
5. Three Reasons We Might Not Need This PR
|
Summary
Bumps seven npm-distributed CLI version pins in the Dockerfiles to the versions published on the npm registry. The bump matches the versions the nightly build already points at.
No CLI was dropped from this bump.
Not included, each in its own PR:
Registry sources
Each new version was checked against the npm registry before the pin changed:
Files changed
validate-packaged-pinsjob hardcodes the expectedCODEX_VERSIONandCOPILOT_VERSIONvalues, so its twoassert_linelines move to the new pins)Dockerfile sync rule
Each CLI pin is an
ARG <CLI>_VERSION=<value>line that appears in three Dockerfiles:Dockerfile.unified,Dockerfile.package, and the CLI's own Dockerfile. Every copy moved to the new value. That gives 3 copies per CLI and 21ARGlines in total. A grep for each oldARGvalue returns no matches in the changed files. The unchanged pins (KIRO, CLAUDE_*, CODEX_ACP, GROK, DEVIN, PI_CODING_AGENT) keep their old values.docs/kimi.mdhas no version number to change.Review Contract
Goal
Move the seven npm CLI pins in the Dockerfiles to the versions currently published on npm, so the images ship current CLIs and match the nightly build.
Non-goals
Accepted Residual Risks
Acceptance Criteria
ARGpin listed in the summary table reads the new version in all three Dockerfiles that carry it. The grep check above is the evidence.Dockerfile.unifiedandDockerfile.packageimages build with the new pins. Status: PASS, covered by the smoke-test and smoke-test-unified jobs (https://github.com/openabdev/openab/actions/runs/41211485832).Follow-ups
Verification
CI smoke tests (
docker-smoke-test.yml) are the verification for this PR. Nothing was built or run locally.