Skip to content

Re-land #341 (openBenches handoff environment) in v1.2.1, with its review's fixes #343

Open

Description

@brettheap

Re-land #341 (OPENBENCHES_CLAUDE_* with the WORKBENCHES_CLAUDE_* fallback in both handoff surfaces) in v1.2.0, with the fixes its review owes.

How it got here:

The branch: 033-openbenches-compatibility at 4e687e2f, with two commits on 33ce26d:

  • 576b39f, "feat: accept openBenches handoff environment";
  • 4e687e2, "fix: avoid eval in Claude environment checks".

What the re-land must add before it merges:

  • From lane 5's independent review (feat: accept openBenches handoff environment #341 6401046464, READY AFTER FIXES):
    • S2: every test scrub that clears WORKBENCHES_CLAUDE_* also clears OPENBENCHES_CLAUDE_*, at the places the review lists. Without that, a host's OPENBENCHES_CLAUDE_LANE_DIR leaks into test_restart_refuses_unsupported_checkout_or_agent_before_preservation[none].
    • S3: tests for:
      • a name set to an empty value;
      • the lifecycle state root in the conflict test's snapshot;
      • where the block sits in the skill;
      • a conflict under --restart, --exit, --in-process and --late.
  • From lane 3's ruling on S1 (feat: accept openBenches handoff environment #341 6401064898):
    • a conflict refuses only where the variable is read, before any write;
    • a conflict in a variable the run does not read prints one line and does not refuse.
  • N1 (Sourcery's eval finding) is answered by 4e687e2.

When: after v1.1.0 is tagged, in the landing order after #303, which changes the same two files. An independent re-check of the fixes, and a merge-tree against #303's branch, come before it lands.

Lane: openRepoTools-3

Activity

  1. added this to the v1.2.0 milestone on Oct 26, 2026
  2. modified the milestones: v1.2.0, v1.2.1 on Nov 8, 2026
  3. changed the title [-]Re-land #341 (openBenches handoff environment) in v1.2.0, with its review's fixes[/-] [+]Re-land #341 (openBenches handoff environment) in v1.2.1, with its review's fixes[/+] on Nov 8, 2026
  4. brettheap commented on Nov 8, 2026

    @brettheap
    ContributorAuthor

    Lane openRepoTools-4, 2026-11-08T13:06Z: this issue is now milestoned v1.2.1 and retitled to match, on Brett's word.

    Lane: openRepoTools-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions