Repository navigation
Bump the code leg from 2a057a6 to e393958, which carries the openRepoShape v1.1.1 pin (opensoft/openRepoTools-code#15) and five T017 merges, moving the code gitlink and contracts/code-pin.yaml together with bump-leg.py (part of opensoft/openRepoTools#186) - #349
Open
brettheap wants to merge 1 commit into
Open
brettheap wants to merge 1 commit into
brettheap wants to merge 1 commit into
Conversation
…Shape v1.1.1 pin (opensoft/openRepoTools-code#15) and five T017 merges, moving the code gitlink and contracts/code-pin.yaml together with bump-leg.py (part of #186) openRepoShape's bump-leg.py made this change, run from the copy of the standard mounted in the code leg at the old pin, openRepoShape 190133d (v1.1.0), as README.md's "The lockstep invariant" says a leg moves: bump-leg.py --root ROOT --leg code \ --to e39395895eac443e7d1f1ddec65e9a3ce829113a What moved: - The gitlink at code/ moves from 2a057a6d84e58c8acb4bda20d2b7b667b552c3fe to e39395895eac443e7d1f1ddec65e9a3ce829113a, code main at the merge of opensoft/openRepoTools-code#15. - `commit:` and `digests.tree_sha256` in contracts/code-pin.yaml move with it. `tree_sha256` goes from 31123e2d08efe36583e72956ed8b8dbbe4b968c75402b59af5b8952be83ef6d5 to 72a75178cdec3ef57ced77520846a67b0673e2e0cef6b88a28b6e937743b0c6d, which the tool recomputed from the leg's own objects under sorted-ls-tree-r-v1. It is not adjusted. - No workflow reference names the code leg, so none moves. The spec gitlink, 64a1a989fe7b04daf3bc2a236739a01f0aa7291a, and every other file are untouched. What e393958 carries, from `git log --oneline --first-parent 2a057a6d..e393958` in the code leg: - opensoft/openRepoTools-code#15 (e393958) pins openRepoShape at v1.1.1, 5017830 on its main: four of the eight mounted files moved, and no test expectation moved. - Five T017 merges, oldest first: - 609ad61, opensoft/openRepoTools-code#3: a lane whose recorded dir holds a space is no longer left out of worktrees --all and the inventory index (#295). - c23f535, opensoft/openRepoTools-code#4: a dir with a TAB or a backslash is listed, indexed and reached as recorded, a stored sub-field reads back as written, and request-handoff refuses a host or container the fence rejects (#301). - 70632d3, opensoft/openRepoTools-code#5: a lane control root that cannot be searched is read as not read, not as no trees (#291). - e527b5d, opensoft/openRepoTools-code#6: a tree record that names no absolute path makes its lane UNREAD, so a sync and a reconcile keep the lane's rows (#302). - 577110e, opensoft/openRepoTools-code#7: where a lane's log or register cannot be read, a named worktree read is UNREAD, not none (#290). Brett Heap ruled v1.1.1 on 10-22, and his word "v1.1.1 b" orders the work as B, then A and C, each landing on his word, with no release. B is opensoft/openRepoTools-code#15, landed as code e393958. A is #348, landed as root e00ddd8. This is C, the last of the three: it brings this root's code gitlink and pin to the commit that holds B. There is no release and no tag, and this moves the root's own pins only. Inside its run the tool ran the root's own validate-pins.py and validate-manifest.py after the rewrite, and both passed. A second run with the copy of bump-leg.py at openRepoShape v1.1.1 gave the same tree. Lane: openRepoTools-1 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Sorry @brettheap, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 5 days and 21 hours by commenting |
Reviewer's GuideLock files and vendored codeMove the code gitlink and its recorded commit and tree digest together to the new pinned revision.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Lane: openRepoTools-1
Claim: #186 (comment)
What changes
openRepoShape's
bump-leg.pymoves this assembly root'scodeleg from2a057a6d84e58c8acb4bda20d2b7b667b552c3fetoe39395895eac443e7d1f1ddec65e9a3ce829113a, which is codemainat the merge ofopensoft/openRepoTools-code#15. It writes the lockstep commit README.md's "The lockstep invariant" describes, with the command:code/moves toe39395895eac443e7d1f1ddec65e9a3ce829113a.contracts/code-pin.yaml:commit:moves to the same commit.digests.tree_sha256moves from31123e2d08efe36583e72956ed8b8dbbe4b968c75402b59af5b8952be83ef6d5to72a75178cdec3ef57ced77520846a67b0673e2e0cef6b88a28b6e937743b0c6d, which the tool recomputed from the leg's own objects undersorted-ls-tree-r-v1. It is not adjusted.@<sha>reference names the code leg, so none moves. Thespecgitlink (64a1a989fe7b04daf3bc2a236739a01f0aa7291a) and every other file are untouched.Size. 2 files, 3 insertions and 3 deletions. The old gitlink is an ancestor of the new one in the code leg, so this is a fast-forward of the leg.
What e393958 carries
From
git log --oneline --first-parent 2a057a6d..e393958in the code leg:opensoft/openRepoTools-code#15(e393958), pins openRepoShape at v1.1.1,5017830on itsmain: four of the eight mounted files moved, and no test expectation moved. In the code leg,contracts/openreposhape-pin.yamland theupstream/openRepoShapegitlink move from190133dto5017830.609ad61,opensoft/openRepoTools-code#3: a lane whose recorded dir holds a space is no longer left out ofworktrees --alland the inventory index (opensoft/openRepoTools#295).c23f535,opensoft/openRepoTools-code#4: a dir with a TAB or a backslash is listed, indexed and reached as recorded, a stored sub-field reads back as written, andrequest-handoffrefuses a host or container the fence rejects (opensoft/openRepoTools#301).70632d3,opensoft/openRepoTools-code#5: a lane control root that cannot be searched is read as not read, not as no trees (opensoft/openRepoTools#291).e527b5d,opensoft/openRepoTools-code#6: a tree record that names no absolute path makes its lane UNREAD, so a sync and a reconcile keep the lane's rows (opensoft/openRepoTools#302).577110e,opensoft/openRepoTools-code#7: where a lane's log or register cannot be read, a named worktree read is UNREAD, not none (opensoft/openRepoTools#290).Why
Brett Heap ruled v1.1.1 on 10-22, and answered "v1.1.1 b" (#186 (comment)). His word orders the work as B, then A and C, each landing on his word, with no release. Both of the triad's openRepoShape pins move: this root's shape copies (A) and the code leg's mounted pin (B). C records B in this root.
opensoft/openRepoTools-code#15, landed as codee393958.e00ddd8. It re-synced this root's shape copies to v1.1.1.codegitlink and pin to the commit that holds B and the five T017 merges before it.Lane 2's W2 runbook
Its PKA-9 check needs this root's
codegitlink to be an ancestor of W2's composed code tip. W2 mergese393958in place, so PKA-9 still holds after this pull request lands.Which copy of the tool
The run used the copy at the old pin:
code/upstream/openRepoShape/scripts/bump-leg.py, at openRepoShape190133d(v1.1.0), from a fresh clone ofmainon the branchchore/code-leg-e393958, because the tool refuses a root on its tracking branch. The copy at v1.1.1 (5017830) differs inbump-leg.py, by 127 changed lines. It refuses alegs:that is not a list of mappings, readstracking_branchand the branch name more strictly, and names paths throughshown_pathin its messages. None of that bears on a bump of this well-formed root from a plain branch. Run on a copy of the same clone, the v1.1.1 copy's dry run printed the same lines and its real run gave the same tree,3563088892cc02ceb8fceb8a224d200ebfc9dd51, and the same message.Checks
On this pull request:
exact-pins(.github/workflows/composed.yml) is the one required check, the only one the repository's rules onmainname. It runs the manifest and lockstep-pin validators, then the code leg's suite, composed, at the pins this pull request records: codee393958and spec64a1a989fe7b.validate(.github/workflows/validate.yml) and SonarCloud also report. They are not required.Checked locally before opening, in a clean environment (
env -i), on this commit with the legs checked out at its pins:bump-leg.pyran the root's ownvalidate-pins.pyandvalidate-manifest.pyafter its rewrite, and both passed (pins ok,manifest ok).scripts/validate-pins.py,scripts/validate-manifest.pyandscripts/validate-repository-naming.py --project project.yamleach exit 0, and so doesmake validate. The pins check printsok code: gitlink == contracts/code-pin.yaml commit e39395895eacandok code: tree digest recomputes (72a75178cdec…).sorted-ls-tree-r-v1digest, recomputed with a separate script (git ls-tree -r -z, sort, sha256), is72a75178…ate393958and31123e2d…at2a057a6, which is the old row.pin-gitlink-mismatch.exact-pinsstep "every context the composed run claims is here" exits 0, run as written, andgit diff --checkis clean.exact-pinsruns it.No release
This moves the root's own pins only. There is no tag and no release, and nothing in the code leg or its
release/v1.1changes.Landing
This pull request lands only on Brett Heap's word, by squash, with the drafted message as an explicit subject and body: its trailers are
Lane: openRepoTools-1, thenCo-Authored-By:.🤖 Generated with Claude Code
Summary by Sourcery
Update the root's code leg and lockstep pin metadata to e393958, incorporating the openRepoShape v1.1.1 pin and accumulated T017 fixes.
Enhancements:
Chores: