Repository navigation
feat(fork): hide Working and Thinking rows outside Normal display mode - #137
Merged
Merged
Conversation
In Messages only, Messages + Dashboard and Chat + Replies, the timeline still drew the Working and Thinking rows under the last user message, in the main list and in the Replies sub-thread view. The agent's work is hidden in these modes and its reply may land in another view, so the rows sat apart from anything they described. The sidebar already shows that the thread is working. The row builder now drops rows of kind `working` and `thinking` when the existing `repliesChosen` flag is set, which is true exactly when the mode is not Normal. The filter runs before the pass that groups adjacent user messages, so a message and a steer after it are grouped as usual. Normal mode and the sidebar are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request hides the Working and Thinking rows in the chat while a thread is in a display mode other than Normal.
改了什么行为
Behaviour change: yes, a web or desktop user whose thread is in Messages only, Messages + Dashboard or Chat + Replies no longer sees the Working or Thinking row in the chat list or the Replies view. Normal threads and the sidebar's Working badge do not change.
Why
These modes show only messages, but both rows still sat under the last user message, apart from the reply that would come. The sidebar already shows Working.
Checks
New tests fail without the change: Messages only draws neither row, and a message and a steer after it are grouped. A Normal case is the control. In a browser, Messages only and Chat + Replies (main list and Replies view) showed neither row during a turn; Normal showed both. Messages only and Normal were also checked at phone size.
Details
workingandthinkingwhenrepliesChosenis set, which is true exactly when the mode is not Normal. It runs before the pass that groups user messages, and only on a full rebuild, not on each streamed text update.isWorkingdoes not change, so scroll-follow, the empty state, the screen-reader announcement and "Edit from here" act as before.MessagesTimeline.logic.ts+7 −2 (import, input field, call);MessagesTimeline.tsx+2 −1 (the added prop, and the prop's comment, a fork line already). Messages + Dashboard gets the same flag as the other two modes. The rule isdisplayModeRowsinapps/web/src/fork/displayMode/displayModeTimeline.ts.