Skip to content

ci: lint and render every chart on every push, gated by ci_check_result - #452

Merged
andibeuge merged 4 commits into
mainfrom
INF-4419-ci-gate
Nov 5, 2026
Merged

andibeuge merged 4 commits into
mainfrom
INF-4419-ci-gate

Conversation

@andibeuge

@andibeuge andibeuge commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Every PR has to run CI, and the result becomes a required status check. Until now, charts only lint/template/kubeval'd the charts on push to main (in release.yaml), and PRs got path-filtered YAML/JSON lint at most.

Description

New ci.yaml, run on every push:

  • helm: the new reusable parcelLab/ci helm.yaml with chartsPath: parcellab. It runs helm dependency build + helm lint + helm template (skipped for the common library chart) for all 5 charts.
  • ci_check_result: fails if helm failed or was cancelled. This becomes the required check.

release.yaml is unchanged, including kubeval before publishing.

Dependency

Uses helm.yaml@v9 from parcelLab/ci#158 (released in v9.2.2).

@andibeuge
andibeuge marked this pull request as ready for review November 5, 2026 13:50
@andibeuge
andibeuge requested review from a team as code owners November 5, 2026 13:50
Copilot AI balanced review requested due to automatic review settings November 5, 2026 13:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T13:52:44.574815Z b8379da Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow lacks a pull_request trigger, so fork PRs can remain blocked waiting for the required ci_check_result check when CI does not run in the fork.

1 open issue
What changed in this PR

Adds chart validation on every branch push and manual dispatch, preparing a required CI status check for the repository’s change-control requirements.

Changes:

  • Calls the reusable Helm workflow at v9 to validate all five charts under parcellab.
  • Adds ci_check_result, which fails when Helm validation fails or is cancelled.
  • Leaves release-time validation and publishing unchanged.
File Description
.github/​workflows/​ci.yaml Adds push-triggered Helm validation and an aggregate status check for branch protection.

Review effort: Balanced

Comment thread .github/workflows/ci.yaml Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8379da81d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/ci.yaml Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the chart-validation workflow and consolidated status check changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@andibeuge
andibeuge merged commit 278ec9b into main Nov 5, 2026
6 checks passed
@andibeuge
andibeuge deleted the INF-4419-ci-gate branch November 5, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants