Repository navigation
Fix crash and boot loop from unset texgen - #348
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update Aurora commit reference aurora-main |
The subproject reference now points to commit 5ffb07e8e7485c8d0974a23decc7cf2f85d269b9. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix · Severity of issue fixed: Medium
Suggested reviewers: theofficialgman
Merge Risk: 
Minimal · up to 72de8
-
No actionable merge-blocking risk is established by the available evidence.
Pre-merge checks: 
5
-
Full details: Linked Issues check
-
Explanation
Issue
#341requires a fix for the runtime crashes during matches and later shader compilation. The whole-PR diff updatesaurora-mainfromdd399416...to5ffb07e.... The PR summary identifies this Aurora update as fixing draws that sample an unconfigured texgen and as caching only compiled pipelines. These changes address the reported crash paths. Issue#341has no separate automated-test requirement.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Bumps aurora to stop aborting on draws that sample an unconfigured texgen and to only cache pipelines that compiled (patchzyy/aurora-wiicompiled#4). Fixes #341
Summary by CodeRabbit