Skip to content

Fix crash and boot loop from unset texgen - #348

Merged
patchzyy merged 1 commit into
mainfrom
fix-unset-texgen-src
Oct 24, 2026
Merged

patchzyy merged 1 commit into
mainfrom
fix-unset-texgen-src

Conversation

@patchzyy

@patchzyy patchzyy commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Bumps aurora to stop aborting on draws that sample an unconfigured texgen and to only cache pipelines that compiled (patchzyy/aurora-wiicompiled#4). Fixes #341

Summary by CodeRabbit

  • Chores
    • Updated the underlying application component to a newer revision. The available change details do not describe any user-facing feature, behavior, or interface changes. No additional end-user impact is specified for this update.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5ba475c3-ade2-44a5-b2f4-b112c538256e
Commits

Reviewing files that changed from the base of the PR and between 4e0e1ed and 72de8c3.

Files selected for processing: 1
  • aurora-main

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

Walkthrough

The aurora-main subproject reference changed from commit dd399416be6346b34450ba37901fbdca9514b0ba to 5ffb07e8e7485c8d0974a23decc7cf2f85d269b9.

Changes: Aurora reference update

Layer / File(s) Summary
Update Aurora commit reference
aurora-main
The subproject reference now points to commit 5ffb07e8e7485c8d0974a23decc7cf2f85d269b9.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: theofficialgman

Merge Risk: Minimal · up to 72de8

No actionable merge-blocking risk is established by the available evidence.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main purpose of the Aurora subproject update: fixing crashes and boot loops caused by unset texgen.
Linked Issues check Passed Issue #341 requires a fix for the runtime crashes during matches and later shader compilation. The whole-PR diff updates aurora-main from dd399416... to 5ffb07e.... The PR summary identifies thi…
Out of Scope Changes check Passed The whole-PR diff contains one change: the aurora-main submodule pointer update. The stated Aurora fixes directly support issue #341. No unrelated source, test, or documentation changes are present.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #341 requires a fix for the runtime crashes during matches and later shader compilation. The whole-PR diff updates aurora-main from dd399416... to 5ffb07e.... The PR summary identifies this Aurora update as fixing draws that sample an unconfigured texgen and as caching only compiled pipelines. These changes address the reported crash paths. Issue #341 has no separate automated-test requirement.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patchzyy
patchzyy merged commit 7678608 into main Oct 24, 2026
7 checks passed
@patchzyy
patchzyy deleted the fix-unset-texgen-src branch October 24, 2026 12:54
This was referenced Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Crash] WiiCompiled Exited with Code 1 or 3

1 participant