Skip to content

chore: changed workflow to merge from internal branch only - #266

Closed
Vector316I71A wants to merge 1 commit into
devfrom
workflowchange
Closed

Vector316I71A wants to merge 1 commit into
devfrom
workflowchange

Conversation

@Vector316I71A

Copy link
Copy Markdown
Contributor

📌 Description

Changed the workflow for pesu-dev/auth to have PR's raised from an internal branch against dev compared to the earlier fork against dev branch.

ℹ️ Fixes / Related Issues
No issue

🧱 Type of Change

Please indicate the type of changes introduced in your PR. Anything left unchecked will be assumed to be non-relevant

  • 🐛 Bug fix – Non-breaking fix for a functional/logic error
  • ✨ New feature – Adds functionality without breaking existing APIs
  • ⚠️ Breaking change – Introduces backward-incompatible changes (API, schema, etc.)
  • 📝 Documentation update – README, docstrings, OpenAPI tags, etc.
  • 🧪 Test suite change – Adds/updates unit, functional, or integration tests
  • ⚙️ CI/CD pipeline update – Modifies GitHub Actions, pre-commit, or Docker build
  • 🧹 Code quality / Refactor – Improves structure, readability, or style (no functional changes)
  • 🐢 Performance improvement – Speeds up auth, profile retrieval, or reduces I/O
  • 🕵️ Debug/logging enhancement – Adds or improves logging/debug support
  • 🔧 Developer tooling – Scripts, benchmarks, local testing improvements
  • 🔒 Security fix – Addresses auth/session/data validation vulnerabilities
  • 🧰 Dependency update – Updates libraries in pyproject.toml, uv.lock

🧪 How Has This Been Tested?

Please indicate how you tested your changes. Completing all the relevant items on this list is mandatory

  • Unit Tests (tests/unit/)
  • Functional Tests (tests/functional/)
  • Integration Tests (tests/integration/)
  • Manual Testing

⚙️ Test Configuration:

  • OS: (Linux- Pop OS)
  • Python: (3.14.8 via uv)
  • Docker build tested

✅ Checklist

Please indicate the work items you have carried out. Completing all the relevant items on this list is mandatory. Anything left unchecked will be assumed to be non-relevant

  • My code follows the CONTRIBUTING.md guidelines
  • I've performed a self-review of my changes
  • I've added/updated necessary comments and docstrings
  • I've updated relevant docs (README or endpoint docs)
  • No new warnings introduced
  • I've added tests to cover my changes
  • All tests pass locally (scripts/run_tests.py)
  • I've run linting and formatting (pre-commit run --all-files)
  • Docker image builds and runs correctly
  • Changes are backwards compatible (if applicable)
  • Feature flags or .env vars updated (if applicable)
  • I've tested across multiple environments (if applicable)
  • Benchmarks still meet expected performance (scripts/benchmark/benchmark_requests.py)

🛠️ Affected API Behaviour

Please indicate the areas affected by changes introduced in your PR

  • app/app.py – Modified /authenticate route logic
  • app/pesu.py – Updated PESU Academy login or profile handling
  • app/exceptions/ – Error types, their status codes or messages
  • app/metrics/ – Metrics collection, exposition or the /metrics token
  • app/docs/ – OpenAPI (Swagger) examples and descriptions

🧩 Models

  • app/models/request.py – Input validation or request schema changes
  • app/models/response.py – Authentication response formatting
  • app/models/profile.py – Profile response schema
  • app/models/upstream.py – Parsing of PESU Academy's login and profile responses

🐳 DevOps & Config

  • Dockerfile – Changes to base image or build process
  • .github/workflows/*.yml – CI/CD pipeline or deployment updates
  • pyproject.toml / uv.lock – Dependency version changes
  • .pre-commit-config.yaml – Linting or formatting hook changes
  • .github/scripts/check_version_bump.py – The CI version check

📊 Benchmarks & Analysis

  • scripts/benchmark/benchmark_requests.py – Performance or latency measurement changes
  • scripts/benchmark/analyze_benchmark.py – Benchmark result analysis changes
  • scripts/run_tests.py – Custom test runner logic or behavior updates

📸 Screenshots / API Demos (if applicable)

NA

🧠 Additional Notes (if applicable)

NA

@Vector316I71A
Vector316I71A requested review from a team and aditeyabaral as code owners November 12, 2026 16:30
@aditeyabaral
aditeyabaral temporarily deployed to workflowchange - pesuauth-dev PR #266 November 12, 2026 16:30 — with Render Destroyed
@aditeyabaral

Copy link
Copy Markdown
Member

Thank you @Vector316I71A for starting this! Your PR was the starting point for moving pesu-dev from forks to branches of each repository. The change turned out to reach beyond CONTRIBUTING and the checker: docs/, the test runner, CI's token permissions, and the agent instructions in pesu-dev/skills along with the regenerated Copilot wrappers. So #267 builds on yours and covers all of it, and supersedes this one. A review there would be very welcome.

This branch was successfully deployed

No deployments
workflowchange - pesuauth-dev PR #266 — 7102b473 Deployed Nov 12, 2026 by aditeyabaral
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants