Repository navigation
chore: accept pull requests only from branches of this repository - #267
Merged
Merged
Conversation
Contributors now clone pesu-dev/auth, push a branch of their own to it and open the pull request from that branch, instead of working on a fork. The PR source checker enforces it: a pull request from a fork, or from dev or main, fails, as does one that targets anything but dev. Every other job needs the checker, so a rejected pull request runs nothing else. Dependabot's and Copilot's branches live in this repository and still pass. CONTRIBUTING, docs/development.md, docs/testing.md and docs/deployment.md describe the new flow: - clone pesu-dev/auth, branch from origin/dev with a name nobody else uses, push to origin; how to re-point a clone made from a fork; how to get write access; - Copilot's cloud agent is assigned here, and its pull request is the pull request; - branches of this repository receive the repository's secrets, so CI runs the live tests on every pull request, as the merge queue and dev already did; - Render deploys every pull request to pesuauth-dev-pr-<number>.onrender.com with staging's environment variables, so a preview's /health reports staging. Copilot Setup Steps now runs on pushes to dev only: a branch with an open pull request would otherwise run it twice, once for the push and once for the pull request. Verified with SKIP=pytest uv run pre-commit run --all-files and uv run pytest tests/unit (613 passed); the full suite and the live tests run in CI on the pull request.
…s repository Bumps .agents/pesudev-skills to the pesu-dev/skills change that moves AGENTS.md, the skills and the roles from forks to branches of pesu-dev/auth (origin/dev instead of upstream/dev, agents push only to branches they created, live tests in CI on every pull request, PR previews). The release-manager role's description changed, so its Copilot wrapper is regenerated with uv run python scripts/sync_agents.py.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
- ci_checks.yml: pull requests now come from branches of this repository and run their own code here, so the workflow token is read-only instead of the repository's write default. The image build keeps packages: write, which its reusable workflow asks for (it pushes nothing on PRs). - ci_checks.yml: the fork rejection says pushing needs write access and where to ask for it. - CONTRIBUTING, deployment.md: never sign in to a PR preview with your own PESU Academy credentials, since it runs unreviewed code. - testing.md, run_tests.py: Dependabot's pull requests get no secrets and run the reduced suite. - development.md: a maintainer pushing regenerated agents onto Dependabot's branch also bumps the version, and how to re-point a fork clone that has no upstream remote. - .agents/pesudev-skills: pesu-dev/skills#10 with the same review fixes.
8 of 47 tasks
The submodule pointed at the branch commit of pesu-dev/skills#10. Its squash merge, b8bceb1, has the same tree, so nothing else changes.
aditeyabaral
temporarily deployed
to
chore/same-repo-branches - pesuauth-dev PR #267
November 13, 2026 05:36 — with
Render
Destroyed
aditeyabaral
enabled auto-merge
November 13, 2026 06:50
jois-code
approved these changes
Nov 13, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Contributors now clone pesu-dev/auth, push a branch of their own to it, and open the pull request from that branch to
dev, instead of working on a fork. This makes CI enforce that, and updates the docs and the agent instructions to match.Supersedes #266. Thank you @Vector316I71A for starting this change; this PR builds on it.
.github/workflows/ci_checks.ymldevormain, or to anything butdev, and says where to ask for write access. Every other job needs it, so a rejected PR runs nothing else. Dependabot's and Copilot's branches are in this repository and still pass.github/workflows/ci_checks.ymlpermissionscontents: read). Fork PRs always got a read-only token, but a branch PR gets the repository's default, which iswrite, while CI runs the PR's unreviewed code. The image build keepspackages: write, because its reusable workflow asks for it; it pushes nothing on PRsCONTRIBUTING.mdorigin/devwith a name nobody else uses, push toorigin; how to get write access; Copilot is assigned here; CI runs the live tests on every PR; PR previews, and never signing in to one with your own credentialsdocs/development.mdupstreamremote); Dependabot follow-ups (a maintainer pushing onto Dependabot's branch also bumps the version, since the Version check runs on that push) and Copilot without forks; the PR source checker; the version check againstorigin/devdocs/testing.mddevdocs/deployment.mdpesuauth-dev-pr-<number>.onrender.com, staging's environment variables,/healthreportsstaging, never sign in with your own credentialsscripts/run_tests.py.envand Dependabot's PRs docopilot-setup-steps.ymldevonly, so a branch with an open PR does not run it twice.agents/pesudev-skills,.github/agents/b8bceb1), which movesAGENTS.md, the skills and the roles to the same flow;release-manager.agent.mdis regenerated because that role's description changed🧱 Type of Change
pyproject.toml,uv.lock🧪 How Has This Been Tested?
tests/unit/)tests/functional/)tests/integration/)uv run pytest tests/unitpassed (613). The functional, integration and live tests were not run locally; CI runs the full suite, live tests included, on this PR, since it comes from a branch of this repository.SKIP=pytest uv run pre-commit run --all-filespasses, includingsync-agentsagainst the new submodule commit, andcheck_version_bump.pyaccepts 5.9.0 → 5.10.0.✅ Checklist
scripts/run_tests.py)pre-commit run --all-files).envvars updated (if applicable)scripts/benchmark/benchmark_requests.py)🛠️ Affected API Behaviour
app/app.py– Modified/authenticateroute logicapp/pesu.py– Updated PESU Academy login or profile handlingapp/exceptions/– Error types, their status codes or messagesapp/metrics/– Metrics collection, exposition or the/metricstokenapp/docs/– OpenAPI (Swagger) examples and descriptions🧩 Models
app/models/request.py– Input validation or request schema changesapp/models/response.py– Authentication response formattingapp/models/profile.py– Profile response schemaapp/models/upstream.py– Parsing of PESU Academy's login and profile responses🐳 DevOps & Config
Dockerfile– Changes to base image or build process.github/workflows/*.yml– CI/CD pipeline or deployment updatespyproject.toml/uv.lock– Dependency version changes.pre-commit-config.yaml– Linting or formatting hook changes.github/scripts/check_version_bump.py– The CI version check📊 Benchmarks & Analysis
scripts/benchmark/benchmark_requests.py– Performance or latency measurement changesscripts/benchmark/analyze_benchmark.py– Benchmark result analysis changesscripts/run_tests.py– Custom test runner logic or behavior updates (a comment only)📸 Screenshots / API Demos (if applicable)
No API change.
🧠 Additional Notes (if applicable)
.agents/pesudev-skillspoints at its squash commit,b8bceb1.developer-teambefore they can push. Please confirm the "ask in#pesu-authon PESU Discord" wording in CONTRIBUTING.TEST_*, but alsoRENDER_API_KEY,DOCKER_*and the org'sRELEASE_BOT_*.TEST_*is accepted so that live tests run on PRs; moving the deploy and release secrets into thestaging/productionenvironments would take the rest out of reach.🤖 Generated with Claude Code