[dpage]

xcrun stapler validate looks the notarisation ticket up in Apple's CloudKit, and when that connection drops it fails with error 68 (NSURLErrorDomain Code=-1005 "The network connection was lost."). That has failed:

• the arm64 build's "Verify the signature and notarisation" step in snapshot-macos.yml, which skipped assembly and acceptance in release candidate 40394287449 even though Gatekeeper had just reported the bundle as accepted, source=Notarized Developer ID, and 3 of the last 14 nightlies at the same step;
• the arm64 macOS acceptance job (run).

Both places now make up to three attempts, 30 and 60 seconds apart, so a genuinely bad ticket still fails, just about a minute and a half later.

Summary by CodeRabbit

• Chores
  • macOS acceptance and release checks retry notarization validation up to three times, with waits between failed attempts. Checks pass as soon as validation succeeds and report a failure if all three attempts fail. Retries apply to the app and disk images in the snapshot workflow; these changes affect validation checks, not app functionality.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pgadmin-org/pgadmin4
• Branch: master
• File: .coderabbit.yaml
• Commit: 0e7c33b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6dde12e8-e371-406d-bc6b-230dcc60507d

Commits

Reviewing files that changed from the base of the PR and between a23c6a1 and de91577.

Files selected for processing: 1

• .github/workflows/snapshot-macos.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The macOS acceptance and snapshot workflows retry xcrun stapler validate up to three times. They wait 30 seconds after the first failure and 60 seconds after the second. Snapshot validation applies to the app and each DMG.

Changes

macOS stapler validation

Layer / File(s)	Summary
Stapler validation retries .github/workflows/acceptance-test.yml, .github/workflows/snapshot-macos.yml	Both workflows retry validation up to three times, with 30- and 60-second waits after the first and second failures. The snapshot workflow uses a helper for the app and each DMG. Validation fails after the third unsuccessful attempt.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• pgadmin-org/pgadmin4#10685: Adds a nightly acceptance job that invokes the macOS acceptance workflow. Its reported arm64 failure occurred during xcrun stapler validate, which this PR retries.

Merge Risk: Minimal · up to de915

The retry behavior is correctly implemented in both macOS workflows, with no established merge-blocking risk.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: retrying xcrun stapler validate in both the macOS build and acceptance checks.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[dpage]

Squashed and pushed to master as 062099a.