[adityaanikam]

Fixes #10695.

has_table_privilege('timetable.chain', 'INSERT, SELECT, UPDATE') is true when the role holds any one of the listed privileges, so a SELECT-only role saw the pgTimeTable Chains node and its create/edit menus, and every save failed with HTTP 500. The check now requires all three. The same query in the test helper is_pgtimetable_installed_on_server is updated to match.

Tested on PostgreSQL 17 with a timetable.chain table and four roles: the old check returns true for SELECT-only and INSERT-only roles, the new one returns true only for the role with all three privileges. pycodestyle passes on both files.

Summary by CodeRabbit

• Bug Fixes
  • Improved detection of pg_timetable availability when checking database access. The check now verifies that the required read, insert, and update permissions are all present, helping the app report availability more accurately when permissions are granted separately. Existing schema and table checks, as well as installation result and error handling, remain unchanged.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pgadmin-org/pgadmin4
• Branch: master
• File: .coderabbit.yaml
• Commit: 48c8b7e
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: e7af8de0-4104-40a0-8384-feda7ae0bb53

Commits

Reviewing files that changed from the base of the PR and between 48c8b7e and 09a7189.

Files selected for processing: 2

• web/pgadmin/browser/server_groups/servers/pg_timetable/__init__.py
• web/pgadmin/browser/server_groups/servers/pg_timetable/tests/utils.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The pgTimeTable backend visibility check and installation test now use separate has_table_privilege calls for INSERT, SELECT, and UPDATE. Both checks require all three privileges.

Changes

pgTimeTable privilege checks

Layer / File(s)	Summary
Require all table privileges web/pgadmin/browser/server_groups/servers/pg_timetable/__init__.py, web/pgadmin/browser/server_groups/servers/pg_timetable/tests/utils.py	The backend visibility check and installation test use separate privilege checks for INSERT, SELECT, and UPDATE. Both require all three checks to pass.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: robe2

Merge Risk: Minimal · up to 09a71

No actionable merge-blocking risk remains from this change.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and accurately describes the main change: requiring INSERT, SELECT, and UPDATE privileges on timetable.chain before showing the pgTimeTable Chains node.
Linked Issues check		The direct issue #10695 requires the Chains node to appear only when the role has INSERT, SELECT, and UPDATE on timetable.chain, or requires a separate read-only design. The PR uses the first option. …
Out of Scope Changes check		The diff changes only the pg_timetable node privilege check and the matching test helper query. Both changes directly support issue #10695. No unrelated behavior or files are changed.

Full details: Linked Issues check

Explanation

The direct issue #10695 requires the Chains node to appear only when the role has INSERT, SELECT, and UPDATE on timetable.chain, or requires a separate read-only design. The PR uses the first option. In ChainModule.backend_supported, three separate has_table_privilege calls are combined with AND. The test helper uses the same all-privileges check. This prevents a role with only one listed privilege from passing the node visibility check.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[dpage]

Thanks! Squashed and merged as e53dc9e.