Skip to content

fix: Show the pgTimeTable Chains node only to roles with INSERT, SELECT and UPDATE on timetable.chain #10698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adityaanikam wants to merge 1 commit into from
Closed

fix: Show the pgTimeTable Chains node only to roles with INSERT, SELECT and UPDATE on timetable.chain #10698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions web/pgadmin/browser/server_groups/servers/pg_timetable/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,10 @@ def backend_supported(self, manager, **kwargs):

status, res = conn.execute_scalar("""
SELECT
has_table_privilege(
'timetable.chain', 'INSERT, SELECT, UPDATE'
(
has_table_privilege('timetable.chain', 'INSERT') AND
has_table_privilege('timetable.chain', 'SELECT') AND
has_table_privilege('timetable.chain', 'UPDATE')
) has_priviledge
WHERE EXISTS(
SELECT has_schema_privilege('timetable', 'USAGE')
Expand Down
6 changes: 4 additions & 2 deletions web/pgadmin/browser/server_groups/servers/pg_timetable/tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,10 @@ def is_pgtimetable_installed_on_server(self):

SQL = """
SELECT
has_table_privilege(
'timetable.chain', 'INSERT, SELECT, UPDATE'
(
has_table_privilege('timetable.chain', 'INSERT') AND
has_table_privilege('timetable.chain', 'SELECT') AND
has_table_privilege('timetable.chain', 'UPDATE')
) has_priviledge
WHERE EXISTS(
SELECT has_schema_privilege('timetable', 'USAGE')
Expand Down
Loading