Skip to content

fix(web): restore dividers beside sidebar section counts - #26403

Open
Microck wants to merge 2 commits into
pingdotgg:mainfrom
Microck:fix/sidebar-section-dividers
Open

Microck wants to merge 2 commits into
pingdotgg:mainfrom
Microck:fix/sidebar-section-dividers

Conversation

@Microck

@Microck Microck commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

the sidebar lost the bars between Working / Snoozed / Settled and their counts during the redesign. this restores the earlier divider span by removing the condition that hides it when an accessory is present, keeping the current theme colors.

this also restores dividers in workflow phase headers, which use the same component.

before after
before after

captures use the real component and app stylesheet in an isolated fixture, with expanded headers above collapsed headers. hosted externally because the available GitHub browser profiles are signed out.

validation: vp run check:changed passed, including formatting, lint, both knip passes, and typecheck of the web and scripts packages. no new tests for this CSS-only change.

written with gpt-6.1-sol in T3 Code through the Codex harness.

@github-actions github-actions Bot added the vouch:unvouched Author is not yet trusted in the VOUCHED list. label Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ea1c1e8

Macroscope's review found this PR approvable — Restores decorative dividers beside sidebar counts and workflow phase details. The change is visual-only, preserving interaction behavior, accessibility attributes, and theme colors.

You can add or adjust custom eligibility rules. Learn more.

@github-actions github-actions Bot added the size:XS 0-9 changed lines (additions + deletions). label Oct 28, 2026
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The collapsible section header keeps its decorative rule visible when an accessory is present. The comment describing the previous hiding behavior was removed.

Changes: Divider visibility

Layer / File(s) Summary
Keep the header rule visible
apps/web/src/components/ui/collapsible-section-header.tsx
The rule no longer gets the invisible class when an accessory is present. The explanatory comment was removed.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Possibly related PRs

  • pingdotgg/t3code#24865: Changed the same header rule’s visibility when a collapsed section has an accessory.

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to 0f53a

This CSS-only change restores the dividers beside the sidebar section counts. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly describes the main change: restoring dividers beside sidebar section counts.
Description check Passed The description explains the problem and change, includes before-and-after screenshots, reports focused validation, and identifies the model and harness. Its account of a specific, narrowly scoped reg…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem and change, includes before-and-after screenshots, reports focused validation, and identifies the model and harness. Its account of a specific, narrowly scoped regression supports the obvious-fix scope exemption.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ea1c1e8 and 0f53aad.

Files selected for processing: 1

  • apps/web/src/components/ui/collapsible-section-header.tsx
Files skipped from review as they are similar to previous changes: 1

  • apps/web/src/components/ui/collapsible-section-header.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

maria-rcks commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by claude-opus-5-5 on behalf of Maria

Takeover: merged current main

merged github/main (e89abadaee) into the branch with a merge commit. head is now 0f53aad3fb. no rebase, no force-push.

  • one conflict in collapsible-section-header.tsx: main changed the label span to min-w-0 truncate (fix(web): lineage phase headers truncate instead of overflowing the details card #27582) on the line next to this fix. kept main's truncation and this PR's always-visible rule. the diff against main is still the same 1 file, +1/-5.
  • no merge-review change was requested for this PR. bot reviews had no findings.
  • vp run check:changed passed on a Blacksmith testbox: format, lint, knip, typecheck (2 packages), react compiler.
  • CI on 0f53aad3fb: 22 successful, 9 skipped, 0 failing. GitHub reports mergeable, clean.
  • re-checked in a real dev server on the merged head with isolated state: Replay threads, one snoozed and two settled through the sidebar context menu. light and dark at 1440×900.

before, main:
main dark: Snoozed 1 and Settled 2 headers with no rule beside the count

after, merged PR head:
pr dark: Snoozed 1 and Settled 2 headers with the rule restored before the count

before, main:
main light: Snoozed 1 and Settled 2 headers with no rule beside the count

after, merged PR head:
pr light: Snoozed 1 and Settled 2 headers with the rule restored before the count

earlier verification (2026-10-30, at ea1c1e8, before the merge)

Verified in a real dev environment

verified as-is at ea1c1e8bee48869240408af4dcafdde90c96c800. no source changes or pushes.

  • reproduced on github/main (5ef56853ef1854da50bc1909c6c0a32700f2cb13) in a separate worktree after vp i. working, snoozed and settled headers all hid their divider beside the count.
  • installed the exact pr head with vp i, stopped main's captured process group, and ran one background vp run dev --home-dir /home/user/t3code/.t3. actual ports: web 5733, server 13773.
  • drove the real web client using the repo's playwright dependency and /usr/bin/google-chrome. added the real git project through the app, created threads and ran codex gpt-6.1-sol turns through the local proxy. no mocks, fixtures or demo data. copied only the isolated, app-created state after stopping main for matching before/after data.
  • on the pr, all three dividers remain visible while expanding and collapsing shelves during a real provider turn. counts and chevrons remain aligned. checked light at 1440×1000 and dark at 1440×1000 and 1100×800.
  • checked neighboring behavior: wake removed the snoozed shelf at zero; re-snooze restored count 1. settling changed settled 1→2; un-settling restored 1. the real codex tool call completed and its reply rendered in the client.
  • inspected the captures and played the uploaded 10-second mp4 through to the end and sought within it. the inline gif contains the same recording. a fresh github read reports 24 successful and 6 skipped contexts, with none failing or pending; no new source checks were run because this verification made no code changes.

before, expanded shelves (main):

main: snoozed and settled counts without dividers

after, same threads and counts (pr; elapsed labels advance naturally):

pr: snoozed and settled counts with restored dividers

pr: expanding and collapsing working, snoozed and settled during a real codex turn

pr: real codex reply rendered in the dark-theme client

short runtime transcript:

main: Working1 / Snoozed1 / Settled1 -> divider visibility: hidden
pr:   Working1 / Snoozed1 / Settled1 -> divider visibility: visible
web composer -> codex gpt-6.1-sol -> timeout 60 sleep 45
provider turn -> completed, error=null
client reply -> "real codex sidebar check passed."
wake -> Snoozed0 (shelf removed); re-snooze -> Snoozed1
settle -> Settled2; un-settle -> Settled1

Not verified

  • the shared component's claude workflow phase header path. these runs used codex; no claude workflow was launched, so its phase counters, failed status and elapsed accessory are unverified.
  • native electron, ios and android clients; macos/windows-specific rendering; relay/tunnel and multi-device connections. this pass exercised the linux web client against the running local server.

@heartwerktech

Copy link
Copy Markdown

please do!

or make it configurable...

something like this would be nice too:

image

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants