Repository navigation
Skip the Carried Verbatim Trees in the Reviewer Configs - #1239
Conversation
Rendered from ptr727/ProjectTemplate's scripts/agent_policy.py at hub 9f3e03c. CodeRabbit and Qodo now skip the trees the hub carries byte for byte, so a finding on hub text lands at the hub rather than on this repository.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
PR Summary by QodoExclude hub-carried trees from reviewer configs
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
|
A recorded local strict-review pass covers head |
Code Review by Qodo
1. Review tools silently skip findings on two directory trees
|
There was a problem hiding this comment.
🟢 Approval recommended
The supplied review evidence reports no active issues, with changes limited to reviewer exclusion settings while preserving the existing configuration.
No open issues 🎉
What changed in this PR
Updates the repository’s automated reviewer configurations to exclude hub-owned, verbatim trees so findings are raised against the canonical source instead.
Changes:
- Adds CodeRabbit exclusions for
.github/skills/**andlib/fleet/sh/**. - Adds matching Qodo/PR-Agent ignore globs.
- Preserves all existing reviewer settings.
| File | Description |
|---|---|
.pr_agent.toml |
Excludes the carried verbatim trees from PR-Agent/Qodo reviews. |
.coderabbit.yaml |
Excludes the carried verbatim trees from CodeRabbit reviews. |
Review effort: Lite
|
@coderabbitai review |
Action performed
|
|
@qodo-free-for-open-source-projects please dismiss finding 1 (Review tools silently skip findings on two directory trees; .coderabbit.yaml:7-9, .pr_agent.toml:4-5). Declined: the exclusion of .github/skills/** and lib/fleet/sh/** is this PR's stated purpose, not a defect. GOVERNANCE.md on develop states of .github/skills/: 'the fleet Skills, carried whole from the hub and never edited here.' Ownership of that text sits at ptr727/ProjectTemplate, which authors it, so a finding on its content belongs to the hub, and findings on every other path stay enabled in both reviewers. |
I can't dismiss finding 1 right now. The findings catalog for this PR is empty, so I have no stable ID to match to "Review tools silently skip findings on two directory trees." Your reasoning doesn't change that. Dismissals go through the stable finding ID. If the finding shows up in the catalog on a later run, ask me again and I'll dismiss it, provided you're the PR author. You can also dismiss it directly in the Qodo UI. If you want to narrow the exclusions rather than dismiss the finding, the rule's scope can be edited on the Rule 3008765 page in the Qodo portal (https://app.qodo.ai/rules/3008765?state=active). The exclusions themselves are in |
Summary
Writes the reviewer configs the hub now renders for this repository, from
ptr727/ProjectTemplate'sscripts/agent_policy.pyat hub9f3e03c(ptr727/ProjectTemplate#4020)..coderabbit.yamlgainsreviews.path_filtersexcluding.github/skills/**andlib/fleet/sh/**..pr_agent.tomlgains an[ignore]globnaming the same trees.Both trees are hub text the repository carries byte for byte, so a reviewer's finding on them belongs at the hub rather than here. Every other setting in both files is unchanged.
Verification
.pr_agent.tomlfrom the default branch, so its exclusion binds once this reachesmain.Summary by CodeRabbit