Skip to content

Skip the Carried Verbatim Trees in the Reviewer Configs - #1239

Merged
ptr727 merged 1 commit into
developfrom
reviewer-skip-carried-trees
Nov 10, 2026
Merged

ptr727 merged 1 commit into
developfrom
reviewer-skip-carried-trees

Conversation

@ptr727

@ptr727 ptr727 commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Writes the reviewer configs the hub now renders for this repository, from ptr727/ProjectTemplate's scripts/agent_policy.py at hub 9f3e03c (ptr727/ProjectTemplate#4020).

  • .coderabbit.yaml gains reviews.path_filters excluding .github/skills/** and lib/fleet/sh/**.
  • .pr_agent.toml gains an [ignore] glob naming the same trees.

Both trees are hub text the repository carries byte for byte, so a reviewer's finding on them belongs at the hub rather than here. Every other setting in both files is unchanged.

Verification

  • The diff is six added lines, three per file. Both files parse, and the existing settings and line endings are unchanged.
  • A recorded local strict review pass found nothing, and the diff-scoped prose gate is clean.
  • Qodo reads .pr_agent.toml from the default branch, so its exclusion binds once this reaches main.

Summary by CodeRabbit

  • Chores
    • Updated automated review settings so selected internal guidance and shell-script areas are excluded from review scope. Changes to those areas will no longer be included in automated reviews.

Rendered from ptr727/ProjectTemplate's scripts/agent_policy.py at hub 9f3e03c.
CodeRabbit and Qodo now skip the trees the hub carries byte for byte, so a
finding on hub text lands at the hub rather than on this repository.
Copilot AI lite review requested due to automatic review settings November 10, 2026 00:27
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CodeRabbit and PR Agent configurations now exclude .github/skills/** and lib/fleet/sh/** from review.

Changes: Review path exclusions

Layer / File(s) Summary
Configure ignored paths
.coderabbit.yaml, .pr_agent.toml
Both configurations add exclusions for .github/skills/** and lib/fleet/sh/**.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Suggested labels: chore

Merge Risk: Minimal · up to e0fe2

The change excludes the carried trees from review; no merge-blocking risk was identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the exclusions for carried verbatim trees in the reviewer configurations.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 632b59c and e0fe260.

Files selected for processing: 2

  • .coderabbit.yaml
  • .pr_agent.toml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Exclude hub-carried trees from reviewer configs

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Exclude hub-carried skill and shell trees from CodeRabbit and Qodo reviews.
• Keep findings on verbatim hub content directed to the hub, without changing other reviewer
 settings.
Diagram

graph TD
  CR["CodeRabbit"] --> CRC[".coderabbit.yaml"] -->|excludes| Trees["Hub-carried trees"]
  Q["Qodo"] --> QC[".pr_agent.toml"] -->|ignores| Trees
Loading
High-Level Assessment

Reviewer-specific path exclusions are the appropriate narrow change: they avoid findings on verbatim hub content without disabling reviews elsewhere. Qodo's exclusion takes effect when this configuration reaches the default branch.

Files changed (2) +6 / -0

Other (2) +6 / -0
.coderabbit.yamlExclude hub-carried trees from CodeRabbit +3/-0

Exclude hub-carried trees from CodeRabbit

• Adds negative review path filters for .github/skills/** and lib/fleet/sh/**. Existing auto-review settings remain unchanged.

.coderabbit.yaml

.pr_agent.tomlIgnore hub-carried trees in Qodo +3/-0

Ignore hub-carried trees in Qodo

• Adds an ignore glob for the same two trees. The existing auto-feedback setting remains unchanged.

.pr_agent.toml

@ptr727

ptr727 commented Nov 10, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head e0fe260ebdca8c5d4cde6ce02b0bb9b9155eb1cc, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Review tools silently skip findings on two directory trees 📘 Rule violation ✧ Quality
Description
The new reviews.path_filters in .coderabbit.yaml and [ignore] glob in .pr_agent.toml exclude
.github/skills/** and lib/fleet/sh/** from CodeRabbit and Qodo review through repository
configuration rather than analysis-tool suppression metadata. When a PR changes either tree,
findings from both reviewers are hidden; for changes to carried review skills, Copilot also loads
the changed skill from the PR head.
Code

.coderabbit.yaml[R7-9]

+  path_filters:
+    - "!.github/skills/**"
+    - "!lib/fleet/sh/**"
Evidence
The added filters in .coderabbit.yaml and .pr_agent.toml exclude the same two trees from
CodeRabbit and Qodo review, hiding otherwise supported findings by default. The repository
configures Qodo for automatic review and CodeRabbit for explicit review, while its Copilot
instructions say Copilot loads review skills from the PR head despite the rule that the carried
skill tree must not be edited locally. The stated intent to defer findings to the hub does not limit
the filters to canonical-content findings or prevent them from applying to future changes.

Rule 3008765: Do not hide or downgrade supported static analysis findings in review output
.coderabbit.yaml[7-9]
.pr_agent.toml[4-5]
.github/agent-policy.json[5-38]
.github/copilot-instructions.md[3-5]
GOVERNANCE.md[321-322]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR adds review-tool exclusions for `.github/skills/**` and `lib/fleet/sh/**` that hide otherwise supported findings by default. In particular, both independent reviewers skip changes to carried review skills even though Copilot consumes those skills from the PR head.
## Fix Focus Areas
- .coderabbit.yaml[7-9]
- .pr_agent.toml[4-5]
## Recommended Fix
Remove the `.github/skills/**` exclusions from both reviewer configurations so changes to carried skills remain independently reviewed for unauthorized edits or instruction tampering, while directing findings about canonical skill content to the hub. Remove the `lib/fleet/sh/**` exclusions as well, unless the hub-ownership rationale is accepted as a documented exception; if retained, record that exception explicitly in the PR description or team policy so the suppression is traceable.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can move or hide resolved findings to focus on what still needs action

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The supplied review evidence reports no active issues, with changes limited to reviewer exclusion settings while preserving the existing configuration.

No open issues 🎉

What changed in this PR

Updates the repository’s automated reviewer configurations to exclude hub-owned, verbatim trees so findings are raised against the canonical source instead.

Changes:

  • Adds CodeRabbit exclusions for .github/skills/** and lib/fleet/sh/**.
  • Adds matching Qodo/PR-Agent ignore globs.
  • Preserves all existing reviewer settings.
File Description
.pr_agent.toml Excludes the carried verbatim trees from PR-Agent/Qodo reviews.
.coderabbit.yaml Excludes the carried verbatim trees from CodeRabbit reviews.

Review effort: Lite

@ptr727

ptr727 commented Nov 10, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727

ptr727 commented Nov 10, 2026

Copy link
Copy Markdown
Owner Author

@qodo-free-for-open-source-projects please dismiss finding 1 (Review tools silently skip findings on two directory trees; .coderabbit.yaml:7-9, .pr_agent.toml:4-5). Declined: the exclusion of .github/skills/** and lib/fleet/sh/** is this PR's stated purpose, not a defect. GOVERNANCE.md on develop states of .github/skills/: 'the fleet Skills, carried whole from the hub and never edited here.' Ownership of that text sits at ptr727/ProjectTemplate, which authors it, so a finding on its content belongs to the hub, and findings on every other path stay enabled in both reviewers.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

free-for-open-source-projects please dismiss finding 1 (Review tools silently skip findings on two directory trees; .coderabbit.yaml:7-9, .pr_agent.toml:4-5). Declined: the exclusion of .github/skills/** and lib/fleet/sh/** is this PR's stated purpose, not a defect. GOVERNANCE.md on develop states of .github/skills/: 'the fleet Skills, carried whole from the hub and never edited here.' Ownership of that text sits at ptr727/ProjectTemplate, which authors it, so a finding on its content belongs to the hub, and findings on every other path stay enabled in both reviewers.

I can't dismiss finding 1 right now. The findings catalog for this PR is empty, so I have no stable ID to match to "Review tools silently skip findings on two directory trees."

Your reasoning doesn't change that. Dismissals go through the stable finding ID. If the finding shows up in the catalog on a later run, ask me again and I'll dismiss it, provided you're the PR author. You can also dismiss it directly in the Qodo UI.

If you want to narrow the exclusions rather than dismiss the finding, the rule's scope can be edited on the Rule 3008765 page in the Qodo portal (https://app.qodo.ai/rules/3008765?state=active). The exclusions themselves are in .coderabbit.yaml (lines 7-9) and .pr_agent.toml (lines 4-5).

@ptr727
ptr727 merged commit 5f32edd into develop Nov 10, 2026
16 checks passed
@ptr727
ptr727 deleted the reviewer-skip-carried-trees branch November 10, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants