Repository navigation
test(core): fix Windows path separator sort in search test - #66
Merged
Merged
Conversation
The empty-query search test sorted the received entries but compared against a fixed-order expected array. On Windows directory entries carry a backslash separator (0x5C) which sorts after the forward slash (0x2F) in file paths, so the received order differed from the hardcoded expected order and the test failed. Sort the expected array too for a platform-independent comparison. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI
testjob has been failing onmain(Windowsunitrunner). The failing test isFileSystemSearch ripgrep fallback > returns entries for an empty queryinpackages/core/test/filesystem/search.test.ts.The test sorts the received entries but compares against a fixed-order expected array:
Directory entries carry the OS path separator (
\= 0x5C on Windows) while ripgrep returns file paths with forward slashes (/= 0x2F). Since/sorts before\, the.sort()ed received order differs from the hardcoded expected order, which only matches the Unix sort. This is a pre-existing latent bug surfaced on the Windows runner.Fix
Sort the expected array with the same comparator so the assertion is platform-independent. No production code changes; the mixed separators are intentional (directory entries append
path.sepby design).Verification
bun test test/filesystem/search.test.tspasses locally (macOS).["README.md", "src/match.ts", "src\"].🤖 Generated with Claude Code