Skip to content

test(core): fix Windows path separator sort in search test #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quickbeard merged 1 commit into from
Jul 14, 2026
Merged

test(core): fix Windows path separator sort in search test #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/core/test/filesystem/search.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,15 @@ describe("FileSystemSearch ripgrep fallback", () => {
yield* Effect.promise(() => fs.writeFile(path.join(cwd, "src", "match.ts"), "needle\n"))
yield* Effect.promise(() => fs.writeFile(path.join(cwd, "README.md"), "# readme\n"))
const entries = yield* findSettled("")
expect(entries.map((entry) => entry.path).sort()).toEqual([
RelativePath.make("README.md"),
RelativePath.make("src" + path.sep),
RelativePath.make("src/match.ts"),
])
// Directory entries carry the OS path separator while ripgrep returns files
// with forward slashes, so sort both sides for a platform-independent compare.
expect(entries.map((entry) => entry.path).sort()).toEqual(
[
RelativePath.make("README.md"),
RelativePath.make("src" + path.sep),
RelativePath.make("src/match.ts"),
].sort(),
)
expect(entries.find((entry) => entry.path === "src" + path.sep)?.type).toBe("directory")
}).pipe(Effect.provide(searchLayer(cwd))),
),
Expand Down
Loading