Repository navigation
Spec 001 T046: the figures step - #154
Closed
adamjohnwright wants to merge 2 commits into
Closed
adamjohnwright wants to merge 2 commits into
adamjohnwright wants to merge 2 commits into
Conversation
Draws the book's figures into a folder before the book: the Figure rules by the book's own code, T024's release-file and character checks before any request, the render service's health and the content release checked, each figure drawn, label-checked, written beside its name and moved into place, its manifest line appended only once the deployment reads unchanged. A figure's own fault leaves it out while the rest are drawn; a deployment changed or gone, or the breaker, stops the run at once. The client names each missing figure's cause and, for figures only, retries a 504 or a timeout once. The render stub gains 500/504, health, a hook, silence and slowness; a content stub is added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced after review: an unanswered figure's path to 'complete' untested; --report could overwrite an earlier report or turn a refusal into exit 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, task T046 (contracts/figures.md, contracts/render.md, SC-010).
What:
pdf-export figures(src/figures/step.ts) draws the book's figures into a folder forbookto read:bookuses), runs T024's release-file and character checks before any request, then refuses a render service whose health isn'tfiles: localor whosebuildisunknown, and a content service of another release;completeis written only on a clean run; the run report is always written.The client now gives a missing figure's cause (
unanswered,failed,refused,invalid) and, forfiguresonly, retries a 504 or a timeout once;serveis unchanged. The render stub gains 500/504 refusals and a settable health; a content stub is added.Tests:
test/figures/step.test.ts(22) and stub and client tests; 391 in all. The complete manifest is checked by T024'scheckFolder. 40 mutants, all killed (tasks.md).🤖 Generated with Claude Code