Repository navigation
Spec 001 T035 follow-up: pdf.js's error never printed whole - #175
Merged
Merged
Conversation
UnreadPdf keeps pdf.js's error in a private field, not as `cause`, which Node prints with the error wherever it prints it whole. Tested by printing the error with util.inspect. Every console writing method is tested held, from the test's own list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, a follow-up to T035 (#173), from its review's lows.
UnreadPdfkept pdf.js's error ascause, which Node prints wherever it prints an error whole (console.error(error), an uncaught error), enumerable or not; pdf.js's message can quote the file's words (people's names, FR-013). Nothing printed it whole today, but nothing stopped it. It now keeps pdf.js's error in a private field, read withpdfError(). Tested by printing the error withutil.inspect(the{ cause }mutant fails).assertandgroupfrom the code's list fails it).Tests:
test/check/unread.test.ts,test/compare/units.test.ts.🤖 Generated with Claude Code