Repository navigation
[perf] Read attribute-class from node attrGroups in RemoveEmptyClassMethodRector - #8705
Merged
Merged
Conversation
…n RemoveEmptyClassMethodRector
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor marker skip in
RemoveEmptyClassMethodRectorreadisAttributeClass()from the class reflection fetched off the scope.The rule already refactors the
Class_node directly, so the#[Attribute]marker can be read straight from$class->attrGroups. This drops theClassReflectiondependency and the extragetClassReflection()fetch for that check. Attribute-ness is never inherited, so the node check is equivalent.Behavior unchanged - all 33 fixtures pass.