Skip to content

[perf] Read attribute-class from node attrGroups in RemoveEmptyClassMethodRector #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 19, 2026
Merged

[perf] Read attribute-class from node attrGroups in RemoveEmptyClassMethodRector #8705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions rules/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\PhpDocParser\Ast\PhpDoc\DeprecatedTagValueNode;
use PHPStan\Reflection\ClassReflection;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
use Rector\Configuration\Parameter\FeatureFlags;
Expand Down Expand Up @@ -176,12 +175,7 @@ private function shouldSkipClassMethod(Class_ $class, ClassMethod $classMethod):
return true;
}

$classReflection = $scope->getClassReflection();
if (! $classReflection instanceof ClassReflection) {
return false;
}

return $this->isAttributeMarkerConstructor($classMethod, $classReflection);
return $this->isAttributeMarkerConstructor($classMethod, $class);
}

private function hasDeprecatedAnnotation(ClassMethod $classMethod): bool
Expand All @@ -197,16 +191,29 @@ private function hasDeprecatedAnnotation(ClassMethod $classMethod): bool
/**
* Skip constructor in attributes as might be a marker parameter
*/
private function isAttributeMarkerConstructor(ClassMethod $classMethod, ClassReflection $classReflection): bool
private function isAttributeMarkerConstructor(ClassMethod $classMethod, Class_ $class): bool
{
if (! $this->isName($classMethod, MethodName::CONSTRUCT)) {
return false;
}

if (! $classReflection->isAttributeClass()) {
if (! $this->isAttributeClass($class)) {
return false;
}

return $classMethod->getDocComment() instanceof Doc;
}

private function isAttributeClass(Class_ $class): bool
{
foreach ($class->attrGroups as $attrGroup) {
foreach ($attrGroup->attrs as $attr) {
if ($this->isName($attr->name, 'Attribute')) {
return true;
}
}
}

return false;
}
}
Loading