Repository navigation
[perf] Hoist cheap node guards before reflection/scope in two rules - #8706
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two refactor() methods paid for reflection or array-callable matching before a cheap node-only guard could bail.
ExplicitAttributeNamedArgsRector -
resolveConstructorReflectionFromAttribute()ran first, but an attribute with no arguments always returns null afterwards. Bail on$node->args === []first, so no-argument attributes (the common case) skip the constructor reflection entirely.ArrayToFirstClassCallableRector - the
IS_CLASS_CONST_VALUE,IS_DEFAULT_PROPERTY_VALUE,IS_PARAM_DEFAULTandIS_UNPACKED_ARG_VALUEattribute checks sat belowarrayCallableMethodMatcher->match(). They are plain node-attribute reads that return null regardless of the match result, so they move up above the match and arrays in those positions skip it.Behavior unchanged - all 37 fixtures across both rules pass.