Skip to content

[perf] Hoist cheap node guards before reflection/scope in two rules #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 19, 2026
Merged

[perf] Hoist cheap node guards before reflection/scope in two rules #8706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rules/CodeQuality/Rector/Attribute/ExplicitAttributeNamedArgsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ public function getNodeTypes(): array
*/
public function refactor(Node $node): ?Node
{
// no arguments to name
if ($node->args === []) {
return null;
}

$methodReflection = $this->reflectionResolver->resolveConstructorReflectionFromAttribute($node);
if (! $methodReflection instanceof MethodReflection) {
return null;
Expand Down
20 changes: 10 additions & 10 deletions rules/Php81/Rector/Array_/ArrayToFirstClassCallableRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,31 +102,31 @@ public function refactor(Node $node): StaticCall|MethodCall|null
return null;
}

$scope = ScopeFetcher::fetch($node);

$arrayCallable = $this->arrayCallableMethodMatcher->match($node, $scope);
if (! $arrayCallable instanceof ArrayCallable) {
if ($node->getAttribute(AttributeKey::IS_CLASS_CONST_VALUE)) {
return null;
}

$callerExpr = $arrayCallable->getCallerExpr();
if (! $callerExpr instanceof Variable && ! $callerExpr instanceof PropertyFetch && ! $callerExpr instanceof ClassConstFetch) {
if ($node->getAttribute(AttributeKey::IS_DEFAULT_PROPERTY_VALUE)) {
return null;
}

if ($node->getAttribute(AttributeKey::IS_CLASS_CONST_VALUE)) {
if ($node->getAttribute(AttributeKey::IS_PARAM_DEFAULT)) {
return null;
}

if ($node->getAttribute(AttributeKey::IS_DEFAULT_PROPERTY_VALUE)) {
if ($node->getAttribute(AttributeKey::IS_UNPACKED_ARG_VALUE)) {
return null;
}

if ($node->getAttribute(AttributeKey::IS_PARAM_DEFAULT)) {
$scope = ScopeFetcher::fetch($node);

$arrayCallable = $this->arrayCallableMethodMatcher->match($node, $scope);
if (! $arrayCallable instanceof ArrayCallable) {
return null;
}

if ($node->getAttribute(AttributeKey::IS_UNPACKED_ARG_VALUE)) {
$callerExpr = $arrayCallable->getCallerExpr();
if (! $callerExpr instanceof Variable && ! $callerExpr instanceof PropertyFetch && ! $callerExpr instanceof ClassConstFetch) {
return null;
}

Expand Down
Loading