Repository navigation
[perf] Bucket value-object renames by old name in 4 Renaming rules - #8739
Merged
Merged
Conversation
RenameStaticMethodRector, RenameClassConstFetchRector, RenamePropertyRector (per-fetch path) and RenameAttributeRector each scanned their whole configured value-object list per visited node, running isName() on each entry before the object-type check. Bucket the list by lowercased old name once in configure(), so a node only visits the entries sharing its name. The lowercased bucket matches the case-insensitive isName() lookup the rules already used, so behaviour is unchanged. bench/rename_static_method_bucket_bench.php (400 renames, 200 non-matching calls): 1002.9 -> 2.3 us/call.
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch A of the configurable-rule config-scan cleanup (follows #8734 / #8735 / #8736). Four more Renaming rules held a flat list of value objects and scanned the whole list per visited node, running
isName()on each entry before the object-type check.RenameStaticMethodRectorRenameClassConstFetchRectorRenamePropertyRector(per-fetch path)RenameAttributeRectorEach builds a bucket keyed by lowercased old name once in
configure(), so a node only visits the entries sharing its name; the object-type / class-type check stays inside the per-bucket branch. The lowercased bucket matches the case-insensitiveisName()these rules already used, so behaviour is unchanged.RenamePropertyRector's ClassLike branch (looks a property up by name directly) is left as is.Numbers
bench/rename_static_method_bucket_bench.php(400 renames, 200 non-matching calls, CPU time):Scales with configured-list size. Full
rules-tests/Renaming(107 tests) green, PHPStan and ECS clean.