Repository navigation
[perf] Key config by method/property name in Add*Type rules - #8744
Open
TomasVotruba wants to merge 1 commit into
Open
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
AddParamTypeDeclarationRector, AddPropertyTypeDeclarationRector and AddReturnTypeDeclarationRector each scanned their whole configured list per visited node, running isName()/isStringName() per entry before the class/object-type check. Bucket the list by lowercased old name once in configure(), so a node only visits the entries sharing its name. AddReturnTypeDeclarationRector dropped its per-node classMethodNames presence hash + full config scan in favour of iterating the class methods and looking each up in the bucket. The lowercased key matches the case-insensitive isName() lookup these rules already used, so behaviour is unchanged. bench/add_property_type_bucket_bench.php (400 entries, 150 non-matching properties): 1063.7 -> 2.4 us/call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch D of the configurable-rule config-scan cleanup (follows #8734 / #8735 / #8736 / #8739 / #8742 / #8743). Three TypeDeclaration rules scanned their whole configured list per visited node, running
isName()/isStringName()on each entry before the class/object-type check.AddParamTypeDeclarationRectorAddPropertyTypeDeclarationRectorAddReturnTypeDeclarationRectorEach builds a bucket keyed by lowercased old name once in
configure(), so a node only visits the entries sharing its name; the class / object-type check stays inside the matched branch.AddReturnTypeDeclarationRectordrops its per-nodeclassMethodNamespresence hash and full config scan, iterating the class methods and looking each up in the bucket. The lowercased key matches the case-insensitiveisName()these rules already used, so behaviour is unchanged.Numbers
bench/add_property_type_bucket_bench.php(400 entries, 150 non-matching properties, CPU time):Scales with configured-list size.
AddParamTypeDeclarationRector/AddPropertyTypeDeclarationRector/AddReturnTypeDeclarationRectortests (18) green, PHPStan and ECS clean.