ENV.keys encoding on Windows was backported to 4.0 and 3.4 - #1398
Merged
Merged
Conversation
eregon
reviewed
Sep 15, 2026
| # https://bugs.ruby-lang.org/issues/20958 | ||
| platform_is :windows do | ||
| ruby_version_is ""..."4.1" do | ||
| ruby_version_is ""..."3.4" do |
Member
There was a problem hiding this comment.
Should use 3.4.11 so it works correctly until that's released.
And for 4.0 we can just update the version we test in CI, I'll do that: #1399
Member
There was a problem hiding this comment.
(3.4.11 not 3.4.10 as 3.4.10 is out and doesn't have the fix according to timing)
Member
There was a problem hiding this comment.
We have a chicken and egg situation: https://github.com/ruby/spec/actions/runs/35029003565/job/104582815330?pr=1399
I'll merge #1399
eregon
force-pushed
the
backport-20958
branch
from
September 15, 2026 22:09
e24b1ce to
b46daf9
Compare
eregon
force-pushed
the
backport-20958
branch
from
September 15, 2026 22:15
b46daf9 to
6e02409
Compare
eregon
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://bugs.ruby-lang.org/issues/20958