Skip to content

ENV.keys encoding on Windows was backported to 4.0 and 3.4 #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 1 commit into from
Sep 15, 2026
+4 −4
Merged

ENV.keys encoding on Windows was backported to 4.0 and 3.4 #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/env/each_key_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@

# https://bugs.ruby-lang.org/issues/20958
platform_is :windows do
ruby_version_is ""..."4.1" do
ruby_version_is ""..."3.4.11" do
it "returns keys in the locale encoding" do
ENV.each_key do |key|
key.encoding.should == Encoding.find('locale')
end
end
end

ruby_version_is "4.1" do
ruby_version_is "3.4.11" do
it "returns the keys in UTF-8" do
ENV.each_key do |key|
key.encoding.should == Encoding::UTF_8
Expand Down
4 changes: 2 additions & 2 deletions core/env/keys_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@

# https://bugs.ruby-lang.org/issues/20958
platform_is :windows do
ruby_version_is ""..."4.1" do
ruby_version_is ""..."3.4.11" do
it "returns the keys in the locale encoding" do
ENV.keys.each do |key|
key.encoding.should == Encoding.find('locale')
end
end
end

ruby_version_is "4.1" do
ruby_version_is "3.4.11" do
it "returns the keys in UTF-8" do
ENV.keys.each do |key|
key.encoding.should == Encoding::UTF_8
Expand Down