bootstrap: add bootstrap step to run stdarch-gen checks in CI by xonx4l · Pull Request #156674 · rust-lang/rust

xonx4l · 2026-05-17T18:22:18Z

This PR ports stdarch-gen checks into the bootstrap test runner as a step, so that we can run the stdarch-gen checks via x.py test.

Changes -:
-> Adds a new StdarchGenCheck bootstrap step.
-> Mirrors https://github.com/rust-lang/stdarch/blob/f71ac102d30d5d1957277cbffc6ba631b67bffd1/.github/workflows/main.yml#L309-L333 (check-stdarch-gen job)
-> stdarch-gen-arm uses a nightly only feature (#![feature(pattern)]) but bootstrap's cargo runs on the beta toolchain thus we set RUSTC_BOOTSTRAP=1 on the child process so it builds.
-> The generators call out to rustfmt to format their output so rustfmt needs to be on PATH. So added bootstrap's rustfmt to PATH before each run. If rustfmt isn't available, the step fails early and tells the user to set rustfmt = true in bootstrap.toml .

r? @Kobzol

rustbot · 2026-05-17T18:22:24Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2026-05-26T13:35:15Z

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

Kobzol

Thank you! I left some comments, the most important one is the question about why things are copied over.

View changes since this review

Kobzol · 2026-08-14T14:17:42Z

@bors try jobs=x86_64-gnu

bootstrap: add bootstrap step to run stdarch-gen checks in CI try-job: x86_64-gnu

rust-bors · 2026-08-14T16:10:42Z

💔 Test for bb3dc02 failed: CI. Failed job:

try - x86_64-gnu (web logs, enhanced plaintext logs)

Kobzol · 2026-08-15T19:05:42Z

@bors try jobs=x86_64-gnu

bootstrap: add bootstrap step to run stdarch-gen checks in CI try-job: x86_64-gnu

rust-bors · 2026-08-15T21:37:08Z

☀️ Try build successful (CI)
Build commit: 397f471 (397f471d92c294d6660a9fc4392f5a6fa1cef566)
Base parent: b4116af (b4116af55fbe359273e2af9e5846a334606d9d6d)

Kobzol

Thank you! Left one more comment, otherwise LGTM.

@bors delegate

View changes since this review

rust-bors · 2026-08-16T08:08:36Z

✌️ @xonx4l, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, then please make that change and post @bors r=Kobzol.

View changes since this delegation.

xonx4l · 2026-08-16T12:06:22Z

@bors r=Kobzol

bootstrap: add bootstrap step to run stdarch-gen checks in CI try-job: test-x86_64-gnu-distcheck

rust-bors · 2026-10-06T13:23:30Z

☀️ Try build successful (CI)
Build commit: 41d9b55 (41d9b552aced9ae6da1c96f171bd4cce83f873d6)
Base parent: b57eb9a (b57eb9a5fd94f30697f51fc88fbe898e67c7aae6)

Kobzol · 2026-10-06T13:53:03Z

Okay, let's try.

Kobzol · 2026-10-06T13:53:07Z

@bors r+

rust-bors · 2026-10-06T13:53:10Z

📌 Commit 70670cf has been approved by Kobzol

It is now in the queue for this repository.

JonathanBrouwer · 2026-10-06T14:25:48Z

@bors p=0

@Kobzol

bootstrap: add bootstrap step to run stdarch-gen checks in CI This PR ports stdarch-gen checks into the bootstrap test runner as a step, so that we can run the stdarch-gen checks via x.py test. Changes -: -> Adds a new `StdarchGenCheck` bootstrap step. -> Mirrors `https://github.com/rust-lang/stdarch/blob/f71ac102d30d5d1957277cbffc6ba631b67bffd1/.github/workflows/main.yml#L309-L333` (check-stdarch-gen job) -> `stdarch-gen-arm` uses a nightly only feature (`#![feature(pattern)]`) but bootstrap's cargo runs on the beta toolchain thus we set `RUSTC_BOOTSTRAP=1` on the child process so it builds. -> The generators call out to `rustfmt` to format their output so `rustfmt` needs to be on `PATH`. So added bootstrap's rustfmt to `PATH` before each run. If rustfmt isn't available, the step fails early and tells the user to set `rustfmt = true` in `bootstrap.toml` . r? @Kobzol

JonathanBrouwer · 2026-10-07T11:22:04Z

@bors yield
Yielding to the rollup since we really need to pass one

rust-bors · 2026-10-07T11:22:08Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/37612972745

The next pull request likely to be tested is #163934.

@Kobzol

bootstrap: add bootstrap step to run stdarch-gen checks in CI This PR ports stdarch-gen checks into the bootstrap test runner as a step, so that we can run the stdarch-gen checks via x.py test. Changes -: -> Adds a new `StdarchGenCheck` bootstrap step. -> Mirrors `https://github.com/rust-lang/stdarch/blob/f71ac102d30d5d1957277cbffc6ba631b67bffd1/.github/workflows/main.yml#L309-L333` (check-stdarch-gen job) -> `stdarch-gen-arm` uses a nightly only feature (`#![feature(pattern)]`) but bootstrap's cargo runs on the beta toolchain thus we set `RUSTC_BOOTSTRAP=1` on the child process so it builds. -> The generators call out to `rustfmt` to format their output so `rustfmt` needs to be on `PATH`. So added bootstrap's rustfmt to `PATH` before each run. If rustfmt isn't available, the step fails early and tells the user to set `rustfmt = true` in `bootstrap.toml` . r? @Kobzol

JonathanBrouwer · 2026-10-07T13:05:49Z

@bors yield

rust-bors · 2026-10-07T13:05:55Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/37625819963

The next pull request likely to be tested is #163934.

@Kobzol

bootstrap: add bootstrap step to run stdarch-gen checks in CI This PR ports stdarch-gen checks into the bootstrap test runner as a step, so that we can run the stdarch-gen checks via x.py test. Changes -: -> Adds a new `StdarchGenCheck` bootstrap step. -> Mirrors `https://github.com/rust-lang/stdarch/blob/f71ac102d30d5d1957277cbffc6ba631b67bffd1/.github/workflows/main.yml#L309-L333` (check-stdarch-gen job) -> `stdarch-gen-arm` uses a nightly only feature (`#![feature(pattern)]`) but bootstrap's cargo runs on the beta toolchain thus we set `RUSTC_BOOTSTRAP=1` on the child process so it builds. -> The generators call out to `rustfmt` to format their output so `rustfmt` needs to be on `PATH`. So added bootstrap's rustfmt to `PATH` before each run. If rustfmt isn't available, the step fails early and tells the user to set `rustfmt = true` in `bootstrap.toml` . r? @Kobzol

JonathanBrouwer · 2026-10-07T20:53:45Z

@bors yield
Yet again yielding to a big rollup, sorry, I think getting the rollups merged should take priority atm

rust-bors · 2026-10-07T20:53:49Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/37684646768

The next pull request likely to be tested is #163957.

rust-bors · 2026-10-08T03:21:15Z

☀️ Test successful - CI
Approved by: Kobzol
Duration: 3h 5m 34s
Pushing 36aeef3 to main...

github-actions · 2026-10-08T03:24:19Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 33ffc9b (parent) -> 36aeef3 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 36aeef32c6c012e1af17af53a820aac042846c43 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-armhf-gnu: 59m 4s -> 1h 39m (+67.8%)
test-x86_64-gnu-aux: 1h 33m -> 2h 37m (+67.7%)
dist-x86_64-solaris: 1h 8m -> 1h 46m (+56.8%)
test-x86_64-gnu-nopt: 1h 37m -> 2h 31m (+55.2%)
test-i686-msvc: 1h 38m -> 2h 30m (+53.0%)
test-x86_64-gnu-llvm-22-3: 1h 20m -> 1h 55m (+43.2%)
test-x86_64-gnu-distcheck: 2h 25m -> 1h 28m (-38.9%)
test-x86_64-msvc-ext3: 1h 25m -> 1h 57m (+37.8%)
test-x86_64-mingw-1: 2h 56m -> 1h 49m (-37.7%)
test-x86_64-gnu-gcc: 1h 25m -> 53m 48s (-37.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-10-08T04:06:19Z

Finished benchmarking commit (36aeef3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Cycles

Results (primary -0.2%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-0.2%	[-2.8%, 2.5%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.731s -> 490.639s (-0.02%)
Artifact size: 408.59 MiB -> 408.64 MiB (0.01%)

rustbot assigned Kobzol May 17, 2026

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 17, 2026