Rollup of 6 pull requests by jhpratt · Pull Request #164957 · rust-lang/rust

jhpratt · 2026-10-26T04:38:03Z

Successful merges:

tools: remote-test-server: Fix UEFI crash return code #164617 (tools: remote-test-server: Fix UEFI crash return code)
feat!: change return type of TryFromIntError::kind #164549 (feat!: change return type of TryFromIntError::kind)
Add diagnostic items for env::vars / env::vars_os #164893 (Add diagnostic items for env::vars / env::vars_os)
Add regression test for CoerceShared impl with unnormalizable target #164897 (Add regression test for CoerceShared impl with unnormalizable target)
Add regression test for self referential inherent associated type ICE #164908 (Add regression test for self referential inherent associated type ICE)
Remove type_array from rustc_codegen_ssa #164926 (Remove type_array from rustc_codegen_ssa)

- compiletest detects crash as an error code > 127. - This does not work for UEFI, since UEFI errors are usize by default, and when converting to i32, we just remove the bits in middle. Eg: 0x8000000000000007 becomes 0x80000007 - So in case of crash, we get a negetive value as error instead of the expected signal when the host is linux. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

…acrum tools: remote-test-server: Fix UEFI crash return code - compiletest detects crash as an error code > 127. - This does not work for UEFI, since UEFI errors are usize by default, and when converting to i32, we just remove the bits in middle. Eg: 0x8000000000000007 becomes 0x80000007 - So in case of crash, we get a negetive value as error instead of the expected signal when the host is linux.

…d-return-type, r=ChrisDenton feat!: change return type of `TryFromIntError::kind` - Tracking issue: rust-lang#153978 Change the return type from `&IntErrorKind` to `IntErrorKind`. Since [`IntErrorKind`](https://doc.rust-lang.org/core/num/enum.IntErrorKind.html) implements the `Copy` trait, I think it should be fine to return an owned type. Returning a reference type is appropriate when we want to ensure the return type matches [`ParseIntError::kind`](https://doc.rust-lang.org/core/num/struct.ParseIntError.html#method.kind).

…Denton Add diagnostic items for env::vars / env::vars_os A WIP Clippy lint that uses this can be found at <https://github.com/rust-lang/rust-clippy/compare/master...notriddle:rust-clippy:manual-env-var?expand=1>

…nilla Add regression test for CoerceShared impl with unnormalizable target Fixes rust-lang#156699 The ICE was fixed by rust-lang#158659

Add regression test for self referential inherent associated type ICE Fixes rust-lang#157774

Remove `type_array` from `rustc_codegen_ssa` It's unused outside of `rustc_codegen_llvm`/`rustc_codegen_gcc`, and shouldn't be used in future in `rustc_codegen_ssa` to help allow backends that don't support immediate aggregate types to use `rustc_codegen_ssa` in the future.

jhpratt · 2026-10-26T04:38:16Z

@bors r+ p=5 force

rust-bors · 2026-10-26T04:38:19Z

📌 Commit ed9f34a has been approved by jhpratt

It is now in the queue for this repository.

JonathanBrouwer · 2026-10-26T06:19:58Z

@bors treeopen

rust-bors · 2026-10-26T06:20:01Z

Tree is now open for merging.

rust-bors · 2026-10-26T07:43:10Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 4m 29s
Pushing aaf324d to main...

github-actions · 2026-10-26T07:46:36Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8592206 (parent) -> aaf324d (this PR)

Test differences

Show 63 test diffs

Stage 1

[ui (polonius)] tests/ui/assumptions_on_binders/self-referential-inherent-assoc-type-issue-157774.rs: [missing] -> pass (J0)
[ui (polonius)] tests/ui/reborrow/coerce-shared-unnormalizable-target-issue-156699.rs: [missing] -> pass (J0)
[ui] tests/ui/assumptions_on_binders/self-referential-inherent-assoc-type-issue-157774.rs: [missing] -> pass (J2)
[ui] tests/ui/reborrow/coerce-shared-unnormalizable-target-issue-156699.rs: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/assumptions_on_binders/self-referential-inherent-assoc-type-issue-157774.rs: [missing] -> pass (J1)
[ui] tests/ui/reborrow/coerce-shared-unnormalizable-target-issue-156699.rs: [missing] -> pass (J1)

Additionally, 57 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard aaf324d50a7dcb17aae7f2a37e15ff143d980c6e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-x86_64-msvc-ext2: 1h 3m -> 1h 51m (+74.9%)
test-i686-msvc: 1h 30m -> 2h 35m (+72.3%)
test-x86_64-msvc-ext1: 1h 30m -> 2h 26m (+62.0%)
dist-i686-linux: 1h 11m -> 1h 52m (+58.7%)
dist-i586-gnu-i586-i686-musl: 18m 8s -> 28m 8s (+55.1%)
test-x86_64-gnu-llvm-22-3: 1h 13m -> 1h 51m (+52.0%)
test-x86_64-rust-for-linux: 37m 5s -> 53m 55s (+45.4%)
test-x86_64-gnu-miri: 1h 25m -> 50m 36s (-40.8%)
test-x86_64-gnu-llvm-22: 53m 17s -> 32m 43s (-38.6%)
test-x86_64-gnu-parallel-frontend: 1h 48m -> 1h 8m (-36.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-bors · 2026-10-26T08:48:56Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#164617	tools: remote-test-server: Fix UEFI crash return code	`b706fdf47d9f0c05cd351e890a8ff856231ce745` (link)
#164549	feat!: change return type of `TryFromIntError::kind`	`279e21665ce96f585e2abb8b52636dd2c3a31cf8` (link)
#164893	Add diagnostic items for env::vars / env::vars_os	`f691fdd7fc9a72677f41103167651cdd0639ab10` (link)
#164897	Add regression test for CoerceShared impl with unnormalizab…	`b38f3f524d4048a30f37b7d1e8f5e0eed6f003a9` (link)
#164908	Add regression test for self referential inherent associate…	`b2960d9bd1c1adf5cee5b16272d6b803d07c12b7` (link)
#164926	Remove `type_array` from `rustc_codegen_ssa`	`08d69510f3b39ee596ff82a8ff133e93e19c6506` (link)

parent commit: 859220648e

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

rust-timer · 2026-10-26T09:04:54Z

Finished benchmarking commit (aaf324d): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.0%, 0.5%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.5%, 1.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.9%, -0.6%]	5
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.9%, 1.0%]	7

Cycles

Results (primary 0.0%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.5%, 0.9%]	6
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-0.8%	[-1.1%, -0.5%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-1.1%, 0.9%]	12

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	67
Improvements ✅ (secondary)	-0.1%	[-0.3%, -0.0%]	56
All ❌✅ (primary)	-0.1%	[-0.2%, -0.0%]	67

Bootstrap: 488.814s -> 488.092s (-0.15%)
Artifact size: 405.93 MiB -> 405.81 MiB (-0.03%)

JonathanBrouwer · 2026-10-26T10:07:13Z

@rustbot label: +perf-regression-triaged
Noise

sorairolake and others added 13 commits October 19, 2026 08:38

feat!: change return type of TryFromIntError::kind

19577f5

style: apply rustfmt

104e47a

Add regression test for CoerceShared impl with unnormalizable target

a0a67f8

Add regression test for self-referential inherent associated type ICE

7d79665

Add diagnostic items for env::vars / env::vars_os

c19a268

Remove type_array from rustc_codegen_ssa

cafe6b8

Rollup merge of rust-lang#164897 - zakrad:regr-test-156699, r=ShoyuVa…

f74ff25

…nilla Add regression test for CoerceShared impl with unnormalizable target Fixes rust-lang#156699 The ICE was fixed by rust-lang#158659

Rollup merge of rust-lang#164908 - zakrad:regr-test-157774, r=chenyukang

b770200

Add regression test for self referential inherent associated type ICE Fixes rust-lang#157774

rust-bors Bot added the rollup A PR which is a rollup label Oct 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2026

This comment has been minimized.

Sign in to view

jhpratt mentioned this pull request Oct 26, 2026

Rollup of 3 pull requests #164959

Closed

JonathanBrouwer mentioned this pull request Oct 26, 2026

Rollup of 6 pull requests #164961

Closed

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2026

rust-bors Bot merged commit aaf324d into rust-lang:main Oct 26, 2026
15 checks passed

rustbot added this to the 1.101.0 milestone Oct 26, 2026

This was referenced Oct 26, 2026

Remove TypeKind from rustc_codegen_ssa #164924

Open

Add strict_ methods to NonZero #164848

Merged

Ensure floats are returned losslessly by the C ABI on 32-bit x86 #161950

Open

rustbot added the perf-regression Performance regression. label Oct 26, 2026

rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 26, 2026

Navigation Menu

Repository navigation

Rollup of 6 pull requests - #164957

Rollup of 6 pull requests#164957
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-K63QGYN

jhpratt commented Oct 26, 2026

Uh oh!

jhpratt commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 26, 2026

Stage 1

Stage 2

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-timer commented Oct 26, 2026

Uh oh!

JonathanBrouwer commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

jhpratt commented Oct 26, 2026

Uh oh!

jhpratt commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 26, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-timer commented Oct 26, 2026

Overall result: ❌ regressions - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants