Reflection add TypeId::name by yara-blue · Pull Request #164981 · rust-lang/rust

yara-blue · 2026-10-26T11:31:22Z

This gets the "name" of an ADT or Trait without any generics unlike type_name.

While this could have been made an argument to the existing Printer it is far simpler and shorter to just duplicate a little code :3

rustbot · 2026-10-26T11:31:25Z

The reflection data structures are tied exactly to the implementation
in the compiler. Make sure to also adjust rustc_const_eval/src/const_eval/type_info.rs

cc @oli-obk

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-10-26T11:31:28Z

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: libs
libs expanded to 37 candidates
Random selection from 7 candidates

yara-blue · 2026-10-26T11:31:53Z

r? @oli-obk

oli-obk · 2026-10-26T15:39:28Z

 }
+
+pub fn type_name<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>) -> String {
+    fn inner<'tcx>(ty: Ty<'tcx>, s: &mut String, tcx: TyCtxt<'tcx>) -> std::fmt::Result {


we can use try blocks in rustc ;)

at least I assume this is the reason for this inner function

View changes since the review

yay, I keep forgetting about all the nice goodies :3

oli-obk

@bors r+ rollup

View changes since this review

rust-bors · 2026-10-28T10:43:46Z

📌 Commit b2d3242 has been approved by oli-obk

It is now in the queue for this repository.

… r=oli-obk Reflection add TypeId::name This gets the "name" of an ADT or Trait without any generics unlike [`type_name`](https://doc.rust-lang.org/stable/std/any/fn.type_name.html). While this could have been made an argument to the existing Printer it is far simpler _and shorter_ to just duplicate a little code :3

…uwer Rollup of 22 pull requests Successful merges: - #165032 (stdarch subtree update) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #164981 (Reflection add TypeId::name) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

… r=oli-obk Reflection add TypeId::name This gets the "name" of an ADT or Trait without any generics unlike [`type_name`](https://doc.rust-lang.org/stable/std/any/fn.type_name.html). While this could have been made an argument to the existing Printer it is far simpler _and shorter_ to just duplicate a little code :3

…uwer Rollup of 23 pull requests Successful merges: - #165032 (stdarch subtree update) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #165123 (Temporarily drop macos-26 jobs) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #164981 (Reflection add TypeId::name) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

rustbot · 2026-10-29T18:02:54Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rust-bors · 2026-10-29T18:03:00Z

⚠️ A new commit 7a7157dc05abffb7549fb4636d44a4ae0253872f was pushed.

This pull request was unapproved.

This PR was contained in a rollup (#165130), which was closed.

JonathanBrouwer · 2026-10-29T20:33:55Z

@bors r=oli-obk

rust-bors · 2026-10-29T20:33:58Z

📌 Commit 7a7157d has been approved by oli-obk

It is now in the queue for this repository.

…uwer Rollup of 21 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) Failed merges: - #164981 (Reflection add TypeId::name)

…uwer Rollup of 22 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #165148 (ci: increase free disk space on macos-26 jobs) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) Failed merges: - #164981 (Reflection add TypeId::name) > [!WARNING] > This rollup conflicts with pending auto build #165205 and may need to be recreated if the pending build succeeds.

… r=oli-obk Reflection add TypeId::name This gets the "name" of an ADT or Trait without any generics unlike [`type_name`](https://doc.rust-lang.org/stable/std/any/fn.type_name.html). While this could have been made an argument to the existing Printer it is far simpler _and shorter_ to just duplicate a little code :3

…uwer Rollup of 22 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #165148 (ci: increase free disk space on macos-26 jobs) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) Failed merges: - #164981 (Reflection add TypeId::name) > [!WARNING] > This rollup conflicts with pending auto build #165205 and may need to be recreated if the pending build succeeds.

Rollup of 19 pull requests Successful merges: - #160370 (rustdoc: notable trait badge and popover enhancements) - #163410 (Use a macro to reduce duplication in `core/src/num/f{16,32,64,128}.rs` (part 1)) - #164290 (virtual function elimination: only use `type.checked.load` for function pointers) - #165113 (Limit lldb string summary length) - #165146 (Stop using LLVM struct types for array/pointer offset GEPs (rebase)) - #165197 (Inline usages of `is_doc_keyword_or_attribute` and `is_rustc_doc_primitive`) - #165209 (Don't ICE when making diagnostic in `point_at_dyn_trait_in_field_def` if there's no `dyn Trait` field to point at) - #153633 (feat: improve `Cell` doc) - #164686 (Add regression test for new solver hang on cyclic projection bound) - #164937 (Add example for misaligned elements in `subslice_range`) - #164981 (Reflection add TypeId::name) - #165035 (Suggest `gca!` for path const args that use generic params) - #165106 (Windows: Disallow some special chars in bat script names) - #165120 (Add regression test for overlap check hang with unresolved type in where clause) - #165158 (Tiny optimization to `TypeErrCtxt::report_inference_failure()`) - #165184 (GCI: Check where-clauses of associated constants for well-formedness) - #165190 (Improve delayed bug comment and message on first_method_vtable_slot) - #165196 (inhabitedness: use try_normalize_erasing_regions on ADT fields) - #165206 (tests: clarify dead_code_pub_in_binary FIXME after Cargo workaround)

rust-bors · 2026-10-31T16:44:32Z

☔ The latest upstream changes (presumably #165234) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This pull request was unapproved.

…uwer Rollup of 23 pull requests Successful merges: - #163410 (Use a macro to reduce duplication in `core/src/num/f{16,32,64,128}.rs` (part 1)) - #164290 (virtual function elimination: only use `type.checked.load` for function pointers) - #165113 (Limit lldb string summary length) - #165146 (Stop using LLVM struct types for array/pointer offset GEPs (rebase)) - #165197 (Inline usages of `is_doc_keyword_or_attribute` and `is_rustc_doc_primitive`) - #165209 (Don't ICE when making diagnostic in `point_at_dyn_trait_in_field_def` if there's no `dyn Trait` field to point at) - #165228 (Fix error output for invalid `SBValue` children) - #153633 (feat: improve `Cell` doc) - #164686 (Add regression test for new solver hang on cyclic projection bound) - #164730 (core: Rename `abort_immediate` to `crash`) - #164937 (Add example for misaligned elements in `subslice_range`) - #165019 (Add safety section for from_utf8_unchecked/from_raw_parts) - #165035 (Suggest `gca!` for path const args that use generic params) - #165106 (Windows: Disallow some special chars in bat script names) - #165120 (Add regression test for overlap check hang with unresolved type in where clause) - #165158 (Tiny optimization to `TypeErrCtxt::report_inference_failure()`) - #165184 (GCI: Check where-clauses of associated constants for well-formedness) - #165190 (Improve delayed bug comment and message on first_method_vtable_slot) - #165196 (inhabitedness: use try_normalize_erasing_regions on ADT fields) - #165206 (tests: clarify dead_code_pub_in_binary FIXME after Cargo workaround) - #165214 (add MaybeUninit::from_ref) - #165225 (LoongArch: Restore `feature(stdarch_loongarch)` for bootstrap) - #165235 (two LLVM backend cleanups) Failed merges: - #160370 (rustdoc: notable trait badge and popover enhancements) - #164981 (Reflection add TypeId::name)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 26, 2026

rustbot assigned JohnTitor Oct 26, 2026

rustbot assigned oli-obk and unassigned JohnTitor Oct 26, 2026

This comment has been minimized.

Sign in to view

yara-blue force-pushed the reflection-type-id-name branch from 534f5b2 to 4a89ddb Compare October 26, 2026 11:55

oli-obk reviewed Oct 26, 2026

View reviewed changes

Comment thread compiler/rustc_const_eval/src/util/type_name.rs Resolved

oli-obk reviewed Oct 26, 2026

View reviewed changes

Comment thread library/core/src/mem/type_info.rs Resolved

yara-blue force-pushed the reflection-type-id-name branch 2 times, most recently from d71fffe to b4b9603 Compare October 27, 2026 13:02

This comment has been minimized.

Sign in to view

yara-blue force-pushed the reflection-type-id-name branch from b4b9603 to b2d3242 Compare October 27, 2026 13:35

oli-obk approved these changes Oct 28, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2026

JonathanBrouwer mentioned this pull request Oct 28, 2026

Rollup of 22 pull requests #165095

Closed

JonathanBrouwer mentioned this pull request Oct 29, 2026

Rollup of 23 pull requests #165130

Closed

yara-blue added 3 commits October 29, 2026 17:55

reflection: add TypeId::name

ef5be98

reflection: move field-representing-field intrinsics

fc84f78

reflection: add type_name to tests

7a7157d

yara-blue force-pushed the reflection-type-id-name branch from b2d3242 to 7a7157d Compare October 29, 2026 18:02

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 29, 2026

This was referenced Oct 30, 2026

Rollup of 22 pull requests #165165

Closed

Rollup of 21 pull requests #165178

Closed

JonathanBrouwer mentioned this pull request Oct 30, 2026

Rollup of 22 pull requests #165208

Closed

jhpratt mentioned this pull request Oct 31, 2026

Rollup of 19 pull requests #165217

Closed

JonathanBrouwer mentioned this pull request Oct 31, 2026

Rollup of 23 pull requests #165243

Merged

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 31, 2026

Conversation

yara-blue commented Oct 26, 2026

Uh oh!

rustbot commented Oct 26, 2026

Uh oh!

rustbot commented Oct 26, 2026

Uh oh!

yara-blue commented Oct 26, 2026

Uh oh!

This comment has been minimized.

oli-obk Oct 26, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yara-blue Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Oct 28, 2026

Uh oh!

rustbot commented Oct 29, 2026

Uh oh!

rust-bors Bot commented Oct 29, 2026

Uh oh!

JonathanBrouwer commented Oct 29, 2026

Uh oh!

rust-bors Bot commented Oct 29, 2026

Uh oh!

rust-bors Bot commented Oct 31, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

oli-obk Oct 26, 2026 •

edited by rustbot

Loading

oli-obk left a comment •

edited by rustbot

Loading