Repository navigation
Rollup of 7 pull requests - #165886
Closed
JonathanBrouwer wants to merge 29 commits into
Closed
Rollup of 7 pull requests#165886JonathanBrouwer wants to merge 29 commits into
JonathanBrouwer wants to merge 29 commits into
Conversation
after some discussion, we decided we want view types to be `!Sized`, at least at the beginning. this commit updates the test suite so that view types are not passed by value anymore.
this commit is quite big because we want to always exhaustively match on all the `TyKind` variants. none of the `unimplemented!()` is reachable because we don't *actually* lower view types (yet!).
/!\ the test suite is has not been updated /!\ the `unreachable!()`s added previously are suddenly reached, triggering literally all the view types test suite to ICE. this is fixed by the next commit.
…direct-load, r=bjorn3 Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct` This is unreachable now that we don't use `PassMode::Direct` for aggregates, as `OperandValue::Ref` is only used for non-ZST `BackendRepr::Memory`. r? @bjorn3
…g, r=oli-obk view-types: lower view types from HIR
…egression, r=folkertdev tests: cover MSVC ThinLTO exported symbol preservation test-only continuation of rust-lang#165458 this pr adds regression tests for exported-symbol preservation during ThinLTO on i686 MSVC. the test checks that ThinLTO preserves: ordinary exported functions, where LLVM IR names differ from COFF linker-visible names. stdcall functions with explicitly decorated symbol names. exported static data. the run-make test executes on x86_64 MSVC and cross-compiles an i686 MSVC static library using `minicore`, so it does not require an installed i686 standard-library sysroot. Verified the test against both implementations: before the fix: test fails because ThinLTO does not preserve `___rust_lto_preserve_plain`. after the fix: test passes with all expected exported symbols present. both fixture compilation steps succeeded in the failing run, confirming that the failure is caused by incorrect symbol preservation rather than a compilation or linking issue. r? @folkertdev
…utes, r=oli-obk reflection: reflect attributes from adts, fields, and variants Introduced a new attribute tool `reflection_placeholder` behind the `TypeId` feature gate. Added intrinsics and methods to query there tool attributes from adts, fields, and variants. Uncertain if the stringifying of the attribute objects before returning them is the right approach. Alternatively, a specific tool attribute structure could be introduced and returned instead of strings. The feature gating also, erroneously, triggers when a user registers a tool attribute with the same name using the `register_tool` feature.
…ieyouxu Update `sysinfo` version to `0.40.3`
cg_llvm: Use an invariant lifetime brand for LLVM attributes This PR changes the type of LLVM attribute references from `&'ll Attribute` to `Attribute<'ll>` with an invariant lifetime brand, to help uphold soundness of the FFI bindings. There should be no change to compiler output. --- After the value migration, this step is thankfully much smaller.
…uwer Some attribute related cleanups
rustbot
added
A-attributes
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 12, 2026
…uwer Rollup of 7 pull requests Successful merges: - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`) - #165565 (view-types: lower view types from HIR) - #165771 (tests: cover MSVC ThinLTO exported symbol preservation) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165855 (Update `sysinfo` version to `0.40.3`) - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - #165872 (Some attribute related cleanups)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for ca08246 failed: CI. Failed job:
|
rust-bors
Bot
added
the
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
BackendRepr::MemorywithPassMode::Direct#165880 (Remove dead code for returningBackendRepr::MemorywithPassMode::Direct)sysinfoversion to0.40.3#165855 (Updatesysinfoversion to0.40.3)r? @ghost
Create a similar rollup