Skip to content

Remove dead code for returning BackendRepr::Memory with PassMode::Direct - #165880

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
beetrees:remove-return-terminator-direct-load
Nov 13, 2026
Merged

Remove dead code for returning BackendRepr::Memory with PassMode::Direct#165880
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
beetrees:remove-return-terminator-direct-load

Conversation

@beetrees

@beetrees beetrees commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

This is unreachable now that we don't use PassMode::Direct for aggregates, as OperandValue::Ref is only used for non-ZST BackendRepr::Memory.

r? @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2026
@bjorn3

bjorn3 commented Nov 12, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2160f34 has been tentatively approved by bjorn3

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2026
@rust-bors

rust-bors Bot commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⌛ Testing commit 2160f34 with merge cc7634d...

Workflow: https://github.com/rust-lang/rust/actions/runs/43291171465

rust-bors Bot pushed a commit that referenced this pull request Nov 12, 2026
@bors
Auto merge of #165880 - beetrees:remove-return-terminator-direct-load…
cc7634d 
…, r=bjorn3

Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`

This is unreachable now that we don't use `PassMode::Direct` for aggregates, as `OperandValue::Ref` is only used for non-ZST `BackendRepr::Memory`.

r? @bjorn3
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 12, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165880 - beetrees:remove-return-terminator-…
83b239a 
…direct-load, r=bjorn3

Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`

This is unreachable now that we don't use `PassMode::Direct` for aggregates, as `OperandValue::Ref` is only used for non-ZST `BackendRepr::Memory`.

r? @bjorn3
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 12, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented Nov 12, 2026

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-bors Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #165886.

rust-bors Bot pushed a commit that referenced this pull request Nov 12, 2026
@bors
Auto merge of #165886 - JonathanBrouwer:rollup-0VjAJCI, r=JonathanBro…
ca08246 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`)
 - #165565 (view-types: lower view types from HIR)
 - #165771 (tests: cover MSVC ThinLTO exported symbol preservation)
 - #165810 (reflection: reflect attributes from adts, fields, and variants)
 - #165855 (Update `sysinfo` version to `0.40.3`)
 - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
 - #165872 (Some attribute related cleanups)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 12, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165880 - beetrees:remove-return-terminator-…
449f23e 
…direct-load, r=bjorn3

Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`

This is unreachable now that we don't use `PassMode::Direct` for aggregates, as `OperandValue::Ref` is only used for non-ZST `BackendRepr::Memory`.

r? @bjorn3
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 12, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026
@bors
Auto merge of #165891 - JonathanBrouwer:rollup-UscFiPc, r=JonathanBro…
221a337 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164707 (Re-enable rustc profile generation for static linked llvm on Windows x64 builds )
 - #165221 (Canonicalize more comparison operators)
 - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`)
 - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`)
 - #165565 (view-types: lower view types from HIR)
 - #165771 (tests: cover MSVC ThinLTO exported symbol preservation)
 - #165810 (reflection: reflect attributes from adts, fields, and variants)
 - #165823 (Tweak crate error wording and turn them into fatal errors)
 - #165849 (More opt-dist improvements)
 - #165855 (Update `sysinfo` version to `0.40.3`)
 - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
 - #165872 (Some attribute related cleanups)
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2026
@Zalathar
Rollup merge of rust-lang#165880 - beetrees:remove-return-terminator-…
dd9e383 
…direct-load, r=bjorn3

Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`

This is unreachable now that we don't use `PassMode::Direct` for aggregates, as `OperandValue::Ref` is only used for non-ZST `BackendRepr::Memory`.

r? @bjorn3
@Zalathar Zalathar mentioned this pull request Nov 13, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026
@bors
Auto merge of #165897 - Zalathar:rollup-y5GZn9S, r=Zalathar
a5b72c9 
Rollup of 13 pull requests

Successful merges:

 - #164707 (Re-enable rustc profile generation for static linked llvm on Windows x64 builds )
 - #165068 (Change color usage for highlights)
 - #165841 (Tell Miri about the alignment handling in the Windows System allocator)
 - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`)
 - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`)
 - #165565 (view-types: lower view types from HIR)
 - #165622 (small cleanups in rustc_codegen_llvm)
 - #165771 (tests: cover MSVC ThinLTO exported symbol preservation)
 - #165810 (reflection: reflect attributes from adts, fields, and variants)
 - #165823 (Tweak crate error wording and turn them into fatal errors)
 - #165849 (More opt-dist improvements)
 - #165855 (Update `sysinfo` version to `0.40.3`)
 - #165872 (Some attribute related cleanups)

Failed merges:

 - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2026
@Zalathar
Rollup merge of rust-lang#165880 - beetrees:remove-return-terminator-…
f80bf3c 
…direct-load, r=bjorn3

Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`

This is unreachable now that we don't use `PassMode::Direct` for aggregates, as `OperandValue::Ref` is only used for non-ZST `BackendRepr::Memory`.

r? @bjorn3
@Zalathar Zalathar mentioned this pull request Nov 13, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026
@bors
Auto merge of #165899 - Zalathar:rollup-0Z4r2RA, r=Zalathar
0819bae 
Rollup of 11 pull requests

Successful merges:

 - #165068 (Change color usage for highlights)
 - #165841 (Tell Miri about the alignment handling in the Windows System allocator)
 - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`)
 - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`)
 - #165565 (view-types: lower view types from HIR)
 - #165622 (small cleanups in rustc_codegen_llvm)
 - #165771 (tests: cover MSVC ThinLTO exported symbol preservation)
 - #165810 (reflection: reflect attributes from adts, fields, and variants)
 - #165849 (More opt-dist improvements)
 - #165855 (Update `sysinfo` version to `0.40.3`)
 - #165872 (Some attribute related cleanups)

Failed merges:

 - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
@JonathanBrouwer

JonathanBrouwer commented Nov 13, 2026

Copy link
Copy Markdown
Member

@bors try jobs=test-various

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026
@bors
Auto merge of #165880 - beetrees:remove-return-terminator-direct-load…
4dd98d7 
…, r=<try>

Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`


try-job: test-various
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165880 - beetrees:remove-return-terminator-…
ae3304b 
…direct-load, r=bjorn3

Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`

This is unreachable now that we don't use `PassMode::Direct` for aggregates, as `OperandValue::Ref` is only used for non-ZST `BackendRepr::Memory`.

r? @bjorn3
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 13, 2026
Closed
@rust-bors

rust-bors Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 4dd98d7 (4dd98d7474a1cb67cab3ebdab3efc280acfd9964)
Base parent: 75bb7a3 (75bb7a374ff3f5363432a17e8000b50a60a4530c)

rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026
@bors
Auto merge of #165908 - JonathanBrouwer:rollup-xJtzrwC, r=JonathanBro…
323bb5f 
…uwer

Rollup of 18 pull requests

Successful merges:

 - #164828 (When suggesting path of renamed crate, use the renamed name)
 - #164864 (Avoid hoisting uninitialized reads in EarlyOtherwiseBranch)
 - #165068 (Change color usage for highlights)
 - #165221 (Canonicalize more comparison operators)
 - #165841 (Tell Miri about the alignment handling in the Windows System allocator)
 - #165869 (Cleanup: Remove `path_matches` and `value_str` from `AttributeExt`)
 - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`)
 - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`)
 - #165565 (view-types: lower view types from HIR)
 - #165622 (small cleanups in rustc_codegen_llvm)
 - #165745 (Don't ICE when a guard condition is a place of type `!`)
 - #165771 (tests: cover MSVC ThinLTO exported symbol preservation)
 - #165810 (reflection: reflect attributes from adts, fields, and variants)
 - #165823 (Tweak crate error wording and turn them into fatal errors)
 - #165849 (More opt-dist improvements)
 - #165855 (Update `sysinfo` version to `0.40.3`)
 - #165872 (Some attribute related cleanups)
 - #165905 (CI: Use a consistent locale when sorting docker build inputs)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 13, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026
@bors
Auto merge of #165918 - JonathanBrouwer:rollup-FJtyyG0, r=JonathanBro…
80196be 
…uwer

Rollup of 17 pull requests

Successful merges:

 - #164828 (When suggesting path of renamed crate, use the renamed name)
 - #164864 (Avoid hoisting uninitialized reads in EarlyOtherwiseBranch)
 - #165068 (Change color usage for highlights)
 - #165221 (Canonicalize more comparison operators)
 - #165841 (Tell Miri about the alignment handling in the Windows System allocator)
 - #165869 (Cleanup: Remove `path_matches` and `value_str` from `AttributeExt`)
 - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`)
 - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`)
 - #165565 (view-types: lower view types from HIR)
 - #165622 (small cleanups in rustc_codegen_llvm)
 - #165771 (tests: cover MSVC ThinLTO exported symbol preservation)
 - #165810 (reflection: reflect attributes from adts, fields, and variants)
 - #165823 (Tweak crate error wording and turn them into fatal errors)
 - #165849 (More opt-dist improvements)
 - #165855 (Update `sysinfo` version to `0.40.3`)
 - #165872 (Some attribute related cleanups)
 - #165905 (CI: Use a consistent locale when sorting docker build inputs)
@beetrees beetrees mentioned this pull request Nov 13, 2026
Open
@rust-bors
rust-bors Bot merged commit c9414d9 into rust-lang:main Nov 13, 2026
15 of 16 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 13, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026
@bors
Unrolled build for #165880 in rollup 165918
ab6c517 
Rollup merge of #165880 - beetrees:remove-return-terminator-direct-load, r=bjorn3

Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`

This is unreachable now that we don't use `PassMode::Direct` for aggregates, as `OperandValue::Ref` is only used for non-ZST `BackendRepr::Memory`.

r? @bjorn3
@beetrees
beetrees deleted the remove-return-terminator-direct-load branch November 13, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bjorn3 bjorn3

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.102.0

Development

Successfully merging this pull request may close these issues.

4 participants

@beetrees @bjorn3 @JonathanBrouwer @rustbot