Repository navigation
Add safety sections to fxsave/fxrstor intrinsics - #2249
Open
kiana1kaslana wants to merge 1 commit into
Open
kiana1kaslana wants to merge 1 commit into
kiana1kaslana wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @adamgemmell (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
kiana1kaslana
force-pushed
the
safety-doc-fxsr
branch
from
October 12, 2026 03:37
2e4c751 to
a7d28d6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_fxsave,_fxrstor,_fxsave64and_fxrstor64intrinsics are declaredunsafebut carry no# Safetysection, unlike most of the other intrinsics in this crate. This adds the missing sections._fxsavewrites a 512-byte FXSAVE image to memory and_fxrstorreads one back, so the sections state the validity and 16-byte alignment requirements ofmem_addr. For the restore side they additionally require the memory to hold a well-formed FXSAVE image written by a prior save, with a legal value in the MXCSR portion.Doc-only change.