Skip to content

Add safety sections to fxsave/fxrstor intrinsics #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiana1kaslana wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −0
Open

Add safety sections to fxsave/fxrstor intrinsics #2249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crates/core_arch/src/x86/fxsr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ unsafe extern "llvm-intrinsic" {
/// [fxrstor]: http://www.felixcloutier.com/x86/FXRSTOR.html
///
/// [Intel's documentation](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_fxsave)
///
/// # Safety
///
/// - `mem_addr` must be valid for writes of 512 bytes.
/// - `mem_addr` must be 16-byte aligned.
#[inline]
#[target_feature(enable = "fxsr")]
#[cfg_attr(test, assert_instr(fxsave))]
Expand All @@ -47,6 +52,15 @@ pub unsafe fn _fxsave(mem_addr: *mut u8) {
/// [fxrstor]: http://www.felixcloutier.com/x86/FXRSTOR.html
///
/// [Intel's documentation](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_fxrstor)
///
/// # Safety
///
/// - `mem_addr` must be valid for reads of 512 bytes.
/// - `mem_addr` must be 16-byte aligned.
///
/// The 512 bytes at `mem_addr` must form a valid `FXSAVE`-format image,
/// e.g. one written by a prior `_fxsave`/`_fxsave64`. In particular the
/// `MXCSR` portion must hold a value legal for `FXRSTOR`.
#[inline]
#[target_feature(enable = "fxsr")]
#[cfg_attr(test, assert_instr(fxrstor))]
Expand Down
14 changes: 14 additions & 0 deletions crates/core_arch/src/x86_64/fxsr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ unsafe extern "llvm-intrinsic" {
/// [fxrstor]: http://www.felixcloutier.com/x86/FXRSTOR.html
///
/// [Intel's documentation](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_fxsave64)
///
/// # Safety
///
/// - `mem_addr` must be valid for writes of 512 bytes.
/// - `mem_addr` must be 16-byte aligned.
#[inline]
#[target_feature(enable = "fxsr")]
#[cfg_attr(test, assert_instr(fxsave64))]
Expand All @@ -47,6 +52,15 @@ pub unsafe fn _fxsave64(mem_addr: *mut u8) {
/// [fxrstor]: http://www.felixcloutier.com/x86/FXRSTOR.html
///
/// [Intel's documentation](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_fxrstor64)
///
/// # Safety
///
/// - `mem_addr` must be valid for reads of 512 bytes.
/// - `mem_addr` must be 16-byte aligned.
///
/// The 512 bytes at `mem_addr` must form a valid `FXSAVE`-format image,
/// e.g. one written by a prior `_fxsave`/`_fxsave64`. In particular the
/// `MXCSR` portion must hold a value legal for `FXRSTOR`.
#[inline]
#[target_feature(enable = "fxsr")]
#[cfg_attr(test, assert_instr(fxrstor64))]
Expand Down
Loading