Repository navigation
fix(#2839): white hero text for themed App Space banners - #2840
Merged
Merged
Conversation
The Joule/Sapphire App Space hero gradients are dark in both light and dark mode, but the base .hero only inherited --sapShell_TextColor, which resolves to a dark value under the Horizon light theme. That left the banner text near-illegible on the purple gradient (/app-space/?theme=joule in light mode, reported by DJ Adams). Pin the themed hero (and its loading skeleton) to white regardless of the active Horizon palette. Verified via vite dev harness: hero text is rgb(255,255,255) with the fix and rgb(34,53,72) without, in light+joule; dark mode unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #2839 (reported by @qmacro). The App Space overview hero at
/app-space/?theme=joule(and?theme=sapphire) is hard to read in light mode: the banner text renders dark on the purple/blue gradient.Root cause
The base
.herorule setscolor: var(--sapShell_TextColor, #fff). The themed variants override the hero background to a dark gradient but never the text colour, so in the Horizon light theme the text inherits--sapShell_TextColor≈#223548(dark) over a dark gradient → poor contrast.Fix
Pin the themed hero (Joule + Sapphire) and its loading skeleton to white, independent of the active Horizon palette. All four gradients (joule/sapphire × light/dark) are dark, so white is correct in every case.
Verification
Tom's #1 rule — tested the actual rendered component via a vite dev-server harness forcing the Horizon light token +
?theme=joule:colorrgb(255,255,255)✓rgb(34,53,72)(the reported dark text)rgb(255,255,255)✓ (no regression)Pure CSS, scoped to the themed App Space hero. No API, no behaviour change.
Note: the 5 existing
src/app-space/__tests__vitest specs fail on the pristineorigin/DEVbaseline too (stale fetch/loading-state stubs) — unrelated to this change.