Skip to content

fix(#2839): white hero text for themed App Space banners #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jung-thomas merged 1 commit into from
Oct 19, 2026
Merged

fix(#2839): white hero text for themed App Space banners #2840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions hugo-apps/src/app-space/AppSpace.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,6 +1325,25 @@ const emptyStateMessage = computed(() => {
}
}

/* ═══════════════════════════════════════════════════════════════════
Themed heroes — text colour (#2839)
The Joule/Sapphire hero gradients are dark in both light AND dark mode,
but the base .hero only inherits --sapShell_TextColor, which resolves to
a DARK value in the Horizon light theme → near-illegible banner text on
the purple/blue gradient. Pin white here (and on the skeleton) so the
themed hero reads correctly regardless of the active Horizon palette.
═══════════════════════════════════════════════════════════════════ */

.app-space[data-theme="joule"] .hero,
.app-space[data-theme="sapphire"] .hero {
color: #fff;
}

.app-space[data-theme="joule"] .hero-title-skeleton,
.app-space[data-theme="sapphire"] .hero-title-skeleton {
background: rgba(255, 255, 255, 0.18);
}

/* ═══════════════════════════════════════════════════════════════════
Joule Theme — Light Mode
═══════════════════════════════════════════════════════════════════ */
Expand Down
Loading