Repository navigation
🧪 Add comprehensive tests for cleanJsonResponse in extension service worker - #101
google-labs-jules[bot] wants to merge 1 commit into
Conversation
…ns of markdown json fenced codeblocks, and syntax error throws for invalid json inputs.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
These PRs targeted parser-helper.cjs, test-service-worker.js and test-extractor.js, all of which this branch removed, so they cannot merge. Their cases that add coverage now live in the ESM suites: - test-parser-helper.mjs: JSON arrays, whitespace with no fence, and a SyntaxError for a trailing comma, truncated JSON, or plain text (#99, #101). - test-course-context.mjs: null and non-URL input, a #fragment on a course root, a non-Canvas path, and a missing or non-numeric course id (#100). #108's one real fix, `cut` in test-doctor's mock PATH, already reached this branch from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Duplicate of #99, and Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
🎯 What: The
cleanJsonResponsefunction in the background service worker lacked comprehensive unit testing, meaning regressions in how we parse LLM JSON responses could silently break the extension.📊 Coverage: Added explicit assertions covering:
```json```SyntaxError).✨ Result: Test coverage for this critical parser path is significantly increased, making the extension more resilient against subtle formatting variations from the API.
PR created automatically by Jules for task 12738921586776636543 started by @savvides