Repository navigation
🧪 [Testing Improvement] Add comprehensive tests for cleanJsonResponse - #99
google-labs-jules[bot] wants to merge 1 commit into
Conversation
…eanJsonResponse, including plain JSON, code fences, whitespaces, and syntax error tests. Registered it in test/test-extension.sh.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
These PRs targeted parser-helper.cjs, test-service-worker.js and test-extractor.js, all of which this branch removed, so they cannot merge. Their cases that add coverage now live in the ESM suites: - test-parser-helper.mjs: JSON arrays, whitespace with no fence, and a SyntaxError for a trailing comma, truncated JSON, or plain text (#99, #101). - test-course-context.mjs: null and non-URL input, a #fragment on a course root, a non-Canvas path, and a missing or non-numeric course id (#100). #108's one real fix, `cut` in test-doctor's mock PATH, already reached this branch from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Duplicate of #101, and it tests Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
🎯 What: The testing gap addressed
The
cleanJsonResponsefunction inextension/background/parser-helper.jswas previously missing explicit tests, leaving a gap in coverage for LLM response parsing logic.📊 Coverage: What scenarios are now tested
```jsonformat)```format)SyntaxErrorthrows)✨ Result: The improvement in test coverage
The test suite now explicitly validates the string sanitization and JSON parsing logic for this critical utility function. The tests execute consistently as part of the overall Chrome Extension test runner.
PR created automatically by Jules for task 16665445065356677189 started by @savvides