Repository navigation
Fix three small gaps left by the follow-up fixes - #116
Merged
Merged
Conversation
- The slug block stops when the course title placeholder is not replaced, so it no longer leaves an empty exports/project-name/ folder. - check-citation-tiers.py checks codes with commas between them and a citation that one line break splits. New test/test-citation-tiers.py. - The rendered landing test waits up to 2s for Chrome's stderr to close after an exit, so output from helper processes reaches the message. Mutations 54a-54d guard the fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The separator matched only spaces and tabs, so a no-break space between a code and its tier hid the citation. The old per-line match caught it. The docstring now says that one line break can come between two items. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The rendered landing test waited a fixed 320ms after Page.navigate. On a busy CI runner it measured a half-built page, and the mutation job's baseline failed with ".footer-signup button is missing from the page". The test now waits for Page.domContentEventFired (15s at most) before the settle wait. The page's CSS is inline, so a parsed page has its styles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three small problems that the final review of PR #115 found. That review let them wait. It also fixes a timing problem in a test, which the first CI run of this PR found.
<project name>still in it, the block printedPROJECT_NAME_NOT_SET. It then made an empty.idstack/exports/project-name/folder. Now the block stops with exit 1 before it makes the folder. This change is in needs-analysis and course-import.test/check-citation-tiers.pyexamined one line at a time, with only spaces between codes. It did not examine a code before a comma, as in[A-1], [B-2] [T1]. It also did not examine a citation that a line break splits. The checker now finds citation groups in the full file. Commas can come between codes, and one line break can come between two items. A blank line ends a citation. The checker also finds a no-break space between a code and its tier again. The newtest/test-citation-tiers.pytests these forms on small test repos..footer-signup button is missing from the pageat a width of 320. The test waited a fixed 320 ms after it opened the page. A busy runner then measured a page that was not complete. The test now waits forPage.domContentEventFired, for a maximum of 15 seconds, and then for the 320 ms. The CSS of the page is inline, so a parsed page has its styles. Locally, the test passed 20 of 20 runs, and 10 of these ran with all CPU cores busy. This problem has no mutation case, because a mutation cannot make a runner busy each time.Each of fixes 1 to 3 has a regression check. Mutations 54a–54d put each problem back, and each one must fail.
Verification
./test/smoke-test.shpython3 test/test-citation-tiers.pypython3 test/check-citation-tiers.py .python3 test/check-doc-accuracy.py ../test/mutation-test.shidstack made the mutation run before the last commit. That commit changed the separator pattern and the anchor of mutation 54c. 54c was then examined on a copy of the repo, and it still makes 3 unit tests fail. The CI mutation job runs the full suite again.
A separate review examined the first commit. It found no critical or important problems.
Limits
A course with the name "Project Name". The slug block now stops for such a course. The guard compares the slug, so it also finds
<Project Name>and the placeholder with extra spaces.Two possible false reports. The tier checker can now give a false report in two cases. Neither case occurs in the repo:
Both cases give a failure that you can see. Neither case lets an incorrect tier pass.
🤖 Generated with Claude Code