Skip to content

🧹 Fix swallowed error in sidepanel.js executeScript catch block - #90

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-swallowed-error-sidepanel-8815482162685136765
Closed

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-swallowed-error-sidepanel-8815482162685136765

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎯 What: Added console.warn(injectionErr) inside the previously empty catch block for content script injection in extension/sidepanel/sidepanel.js.
💡 Why: Silently swallowing errors makes debugging difficult. Logging the error improves observability and maintainability without altering functionality.
✅ Verification: Verified that tests pass via ./test/test-extension.sh and requested a code review.
✨ Result: A safer, more debuggable codebase.


PR created automatically by Jules for task 8815482162685136765 started by @savvides

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@savvides

Copy link
Copy Markdown
Owner

Duplicate of #93. In #109 this catch in refreshActiveTab is the expected path when the panel has no activeTab grant for the tab yet (the user switched tabs without clicking the icon), so a warning here would fire on every tab switch.

Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the .cjs twins, renames test/test-*.js to .mjs, and rewrites the crawler and side panel). It is up to date with main as of ee79db2.

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

Duplicate of #93. In #109 this catch in refreshActiveTab is the expected path when the panel has no activeTab grant for the tab yet (the user switched tabs without clicking the icon), so a warning here would fire on every tab switch.

Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the .cjs twins, renames test/test-*.js to .mjs, and rewrites the crawler and side panel). It is up to date with main as of ee79db2.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant