🧹 Fix swallowed error in executeScript catch block - #93
google-labs-jules[bot] wants to merge 1 commit into
Conversation
Add `console.warn` inside the `catch` block on `chrome.scripting.executeScript` in the sidepanel to prevent silent errors and facilitate debugging.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Duplicate of #90. In #109 this catch in Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the |
Understood. Acknowledging that this work is a duplicate and superseded by PR #109, and stopping work on this task. |
🎯 What: Modified
extension/sidepanel/sidepanel.jsto add aconsole.warnstatement inside thecatch (injectionErr)block forchrome.scripting.executeScript.💡 Why: Silently swallowing errors makes debugging difficult when the extension fails to inject a content script (e.g. into restricted
chrome://URLs). Surfacing this as a warning in the console aids development and debugging without disrupting normal user flow.✅ Verification: Verified the code diff and ran the entire Chrome Extension test suite via
./test/test-extension.sh, which passed successfully. Code review confirmed the safety and correctness of the change.✨ Result: Improved maintainability and debugging capability for the sidepanel script without changing any existing application behavior.
PR created automatically by Jules for task 7770746484350274776 started by @savvides