Skip to content

Find dates written right after a label and a colon in search_dates - #1496

Merged
AdrianAtZyte merged 7 commits into
scrapinghub:masterfrom
AdrianAtZyte:search-colon-label
Sep 30, 2026
Merged

AdrianAtZyte merged 7 commits into
scrapinghub:masterfrom
AdrianAtZyte:search-colon-label

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Member

Resolves #771

@codspeed

codspeed Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing AdrianAtZyte:search-colon-label (756db17) with master (13da631)

Open in CodSpeed

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (13da631) to head (756db17).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1496   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files         238      238           
  Lines        3438     3439    +1     
=======================================
+ Hits         3400     3401    +1     
  Misses         38       38           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 29, 2026 23:31

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianAtZyte
AdrianAtZyte merged commit 72060dc into scrapinghub:master Sep 30, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search date fails with different separator

2 participants