Skip to content

fix: client SDK release review findings - #416

Merged
hamzahalq merged 1 commit into
releases/r10.0-developfrom
hamza/fix/client-sdk-review
Nov 4, 2026
Merged

hamzahalq merged 1 commit into
releases/r10.0-developfrom
hamza/fix/client-sdk-review

Conversation

@hamzahalq

Copy link
Copy Markdown
Contributor

CodeRabbit findings from #415: an empty id list in a matching selection no longer selects every exchange, a failed lookup after a retry returns null instead of throwing, the Node client refuses mixed or inherited-name inputs, the npm publish job's actions are pinned, and the docs are corrected. Adds a run-now success test and a sign-in count to the bad-token test.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 8
  • ^main$
  • ^master$
  • ^staging$
  • ^development$
  • ^gigstaging$
  • ^develop$
  • ^releases$
  • ^releases/r10.0$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 17cf54f5-4c0e-4d8d-9ccc-b986204b4df9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hamzahalq hamzahalq closed this Nov 4, 2026
@hamzahalq hamzahalq reopened this Nov 4, 2026
@hamzahalq hamzahalq closed this Nov 4, 2026
@hamzahalq hamzahalq reopened this Nov 4, 2026
@hamzahalq hamzahalq closed this Nov 4, 2026
@hamzahalq hamzahalq reopened this Nov 4, 2026
@hamzahalq
hamzahalq merged commit 49064a5 into releases/r10.0-develop Nov 4, 2026
3 of 5 checks passed
@hamzahalq
hamzahalq deleted the hamza/fix/client-sdk-review branch November 4, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants