Skip to content

fix(ci): distinguish handled search redirects from runtime errors #9684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Nov 4, 2026
Merged

fix(ci): distinguish handled search redirects from runtime errors #9684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions apps/sim/scripts/test-organization-search-e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,18 @@ try {
verifyLegacyDraft(undefined, 'assistant')
)
await check('The UI completes without unexpected browser runtime errors', async () => {
await expect.poll(() => browserErrorEventCount).toBe(browserErrorCount)
const handledRedirectCount = () =>
browserErrorEvents.reduce(
(count, event) =>
event.stage === 'Search URLs cannot change an agent conversation into an assistant' &&
event.url === `${baseUrl.origin}${root}/search/chat/${agentId}` &&
event.digest === `NEXT_REDIRECT;replace;${root}/chat/${agentId};307;` &&
event.message.startsWith('Minified React error #419;')
? count + event.count
: count,
0
)
await expect.poll(() => browserErrorEventCount - handledRedirectCount()).toBe(browserErrorCount)
const deniedRecoveries = browserErrorEvents.filter(
(event) =>
event.digest === 'NEXT_HTTP_ERROR_FALLBACK;404' &&
Expand All @@ -1036,7 +1047,11 @@ try {
].includes(event.stage)
)
const recoveryCount = deniedRecoveries.reduce((total, event) => total + event.count, 0)
assert.equal(browserErrorEventCount, recoveryCount, 'Unexpected browser error events')
assert.equal(
browserErrorEventCount,
recoveryCount + handledRedirectCount(),
'Unexpected browser error events'
)
assert.equal(browserErrorCount, recoveryCount, 'Unexpected browser runtime errors')
for (const sample of browserErrorSamples) {
const matchedCount = deniedRecoveries
Expand Down
Loading