Skip to content

fix(ci): distinguish handled search redirects from runtime errors - #9684

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-search-redirect-observer
Nov 4, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-search-redirect-observer

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Distinguish the expected streamed agent-chat redirect recovery from uncaught browser runtime errors in Search acceptance.
  • Match only the existing fixture's stage, source URL, canonical redirect digest and React recovery code; retain all routing, authorization and unexpected-error assertions.

Type of Change

  • Bug fix

Testing

  • The existing hosted acceptance failed before the fix when a handled redirect emitted a window error without an uncaught page error.
  • Existing acceptance and required PR checks passed.
  • Hosted negative control injected a genuine uncaught browser error. All 19 preceding checks passed; the final runtime-error audit rejected it with both error observers recording the event. Remaining unrelated experiment jobs were cancelled after retaining that result.
  • Combined staging validation passed. Two independent source/test-audit reviews and both automated reviewers approved the strict accounting change; no review threads remain.
  • All tests and builds ran on hosted CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing acceptance and real browser negative control passed their expected outcomes
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 4, 2026 9:26pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

This PR lets Search acceptance recognize the expected streamed agent-chat redirect without treating it as an uncaught browser error.

  • The Search browser check counts the handled agent-chat redirect separately.

Reviews (1) · Last reviewed commit: "fix(ci): distinguish handled search redi..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit f0cfdfa into staging Nov 4, 2026
47 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-search-redirect-observer branch November 4, 2026 21:29

This branch was previously deployed

1 inactive deployment
Preview — 725e0490 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant