Repository navigation
homer: handle TCP EOF before HEP writes (#2040) - #2202
Draft
darwvin-dev wants to merge 1 commit into
Draft
darwvin-dev wants to merge 1 commit into
darwvin-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream contribution preparation for #2040.
Change
__established()now detects TCP EOF (read() == 0) and calls the existing reset/retry path before writing the queued HEP message. A zero-length datagram does not trigger TCP EOF behavior.Validation
Do not merge until the regression test and build have been completed.
Upstream submission notes
This is a draft, carried from contributor fork PR darwvin-dev/rtpengine#1.
Unfinished validation: Please refer to the outstanding build, runtime, regression and/or integration tests above. No claim is made that these checks passed. Review for compatibility and completeness before marking ready.
The source branch is behind current upstream master and may require reconciliation before merging.