Skip to content

homer: handle TCP EOF before HEP writes (#2040) #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darwvin-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

homer: handle TCP EOF before HEP writes (#2040) #2202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion daemon/homer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,16 @@ static int __established(struct homer_sender *hs) {
int ret;
GString *gs;

// test connection with a dummy read
// Check for peer shutdown before writing another HEP frame.
ret = read(hs->socket.fd, buf, sizeof(buf));
if (ret == 0 && hs->protocol == SOCK_STREAM) {
// A TCP read of zero bytes means that the peer has closed the
// connection. Never reuse this socket for the next HEP frame.
ilog(LOG_NOTICE, "Homer TCP connection at %s closed by peer",
endpoint_print_buf(&hs->endpoint));
__reset(hs);
return -1;
}
if (ret < 0) {
if (errno != EWOULDBLOCK && errno != EAGAIN) {
ilog(LOG_ERR, "Connection error from Homer at %s: %s",
Expand Down