Repository navigation
kernel-module: guard put_net for partially initialized target outputs (#2190) - #2205
Closed
darwvin-dev wants to merge 1 commit into
Closed
darwvin-dev wants to merge 1 commit into
darwvin-dev wants to merge 1 commit into
Conversation
darwvin-dev
marked this pull request as ready for review
October 17, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-local draft for upstream #2190.
Problem
target_put()iteratestarget.num_destinationseven when an output slot has not been completed.table_new_target()allocates the output array zero-initialized, whiletable_new_output()setsoutput.netonly after crypto initialization and route setup succeed. On deletion of an incomplete target, unconditionalput_net(output.net)can dereference NULL.Change
Only call
put_net()whenoutput.netis non-NULL. Keep the existing crypto and route releases, which tolerate zero-initialized state.Verification still required
put_net(NULL)is the reported crash site (issue author hasn't yet provided this).Draft: plausible targeted fix, not a proven resolution of #2190 until reproduction/debugging.
Upstream submission notes
This is a draft, carried from contributor fork PR darwvin-dev/rtpengine#4.
Unfinished validation: Please refer to the outstanding build, runtime, regression and/or integration tests above. No claim is made that these checks passed. Review for compatibility and completeness before marking ready.
The source branch is behind current upstream master and may require reconciliation before merging.