Skip to content

kernel-module: guard put_net for partially initialized target outputs (#2190) #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darwvin-dev wants to merge 1 commit into from
+5 −1
Closed

kernel-module: guard put_net for partially initialized target outputs (#2190) #2205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion kernel-module/nft_rtpengine.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,11 @@ static void target_put(struct rtpengine_target *t) {
free_crypto_context(&t->outputs[i].encrypt_rtp);
free_crypto_context(&t->outputs[i].encrypt_rtcp);
dst_release(t->outputs[i].dst);
put_net(t->outputs[i].net);
// A target may be deleted while some output slots are still
// uninitialised (or failed during setup). put_net(NULL) can
// dereference NULL; only release a reference we acquired.
if (t->outputs[i].net)
put_net(t->outputs[i].net);
}
kfree(t->outputs);
}
Expand Down