Skip to content

[Android] Keep the press alive while a Pressable waits for another gesture #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 1 commit into from
Oct 27, 2026
Merged

[Android] Keep the press alive while a Pressable waits for another gesture #4639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions packages/react-native-gesture-handler/src/v3/components/StatefulPressable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,13 +311,6 @@ const StatefulPressable = (props: PressableProps) => {
pressableEvent
);
},
onTouchesUp: () => {
if (Platform.OS === 'android' && !isScreenReaderEnabled) {
// Prevents potential soft-locks
stateMachine.reset();
handleFinalize();
}
},
onTouchesCancel: (event) => {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
const pressableEvent = gestureTouchToPressableEvent(event);
stateMachine.reset();
Expand Down Expand Up @@ -402,13 +395,9 @@ const StatefulPressable = (props: PressableProps) => {
event.canceled ? StateMachineEvent.CANCEL : StateMachineEvent.FINALIZE
);

// On iOS the button's cancel can land before the long press's touch
// cancel, or without one, so deliver the press-out here
if (
Platform.OS === 'ios' &&
event.canceled &&
isCurrentlyPressed.current
) {
// The button's cancel can land before the long press's touch cancel,
// or without one, so deliver the press-out here
if (event.canceled && isCurrentlyPressed.current) {
handlePressOut(
pressInEventRef.current ??
viewCenterToPressableEvent(dimensions.current),
Expand Down
Loading