Skip to content

docs(examples): reorder router cost summary - #850

Merged
svonava merged 1 commit into
mainfrom
codex/router-workshop-copy-20261024
Oct 24, 2026
Merged

svonava merged 1 commit into
mainfrom
codex/router-workshop-copy-20261024

Conversation

@svonava

@svonava svonava commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Reorder the opening router table so answer accuracy, accuracy loss, total cost and savings appear before the Sol/Luna/Laya/embedding breakdown. Remove the approximation symbols and keep one explanation of estimated costs and excluded hosting/training costs above the table.

All ten rows retain their existing numerical values. Verified the exact column mapping, absence of approximation symbols, and a clean whitespace check. This change only edits documentation.

Summary by CodeRabbit

  • Documentation
    • Updated the results table to show estimated total costs per 10,000 requests, including answer-model costs and router-related fees.
    • Clarified how Laya serving estimates and SIE Cloud embedding prices are presented, and how savings are calculated.

@svonava
svonava requested a review from a team as a code owner October 24, 2026 20:06
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 9b0fa209-3673-42ce-920a-e00356905075
Commits

Reviewing files that changed from the base of the PR and between a8d14bb and c81c0bf.

Files selected for processing: 1
  • examples/train-a-router/README.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

The router comparison table now combines answer-model costs with router costs in one estimated total. The accompanying note distinguishes Laya serving estimates from SIE Cloud embedding prices and describes savings relative to the unrounded total.

Changes: Router cost comparison

Layer / File(s) Summary
Cost table and notes
examples/train-a-router/README.md
The table combines answer-model and router costs into an estimated total-cost column. The note distinguishes Laya serving estimates from SIE Cloud embedding prices and defines savings relative to the unrounded total.

Possibly related PRs

Suggested reviewers: dragosboca

Priority: Low

Merge Risk: Minimal · up to c81c0

The documentation-only change is ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the documentation change and the reordered router cost summary. It is concise and directly related to the changeset.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@svonava
svonava merged commit 6a61737 into main Oct 24, 2026
19 checks passed
@svonava
svonava deleted the codex/router-workshop-copy-20261024 branch October 24, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant