Repository navigation
ipc4: handler-user: bound data_off_size in vendor config get - #11298
Open
Shrusti-pk wants to merge 1 commit into
Open
Shrusti-pk wants to merge 1 commit into
Shrusti-pk wants to merge 1 commit into
Conversation
The userspace large-config get path reads data_off_size straight from the host message and, for a vendor config, hands it to the vendor reader which divides it by sizeof(struct sof_tl) and walks that many entries out of the hostbox. data_off_size is a 20-bit host field so it can claim far more than the 4 KiB hostbox, over-reading roughly 1 MiB past it. The sibling get path and the vendor set path both already reject a data_off_size larger than the mailbox; this one was missed. Add the same bound before the cache invalidate and the read. Signed-off-by: Shrushti P K <shrusthi@labs.digiscrypt.com>
Shrusti-pk
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 13, 2026 07:16
Collaborator
|
Can one of the admins verify this patch?
|
lgirdwood
approved these changes
Oct 13, 2026
Member
|
test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the userspace large-config get path trusts the host data_off_size for a vendor config:
bound it before the cache invalidate and the read, matching the two siblings.